Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 184233005: Pre-cache PLY yacc parse table and use optimized mode (45% build time improvement) (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, Nico, Daniel Bratell
Visibility:
Public.

Description

Pre-cache PLY yacc parse table and use optimized mode (45% build time improvement) PLY yacc parse table creation is (obviously) expensive. Pre-caching this in a separate build step substantially improves build time. Improves build time (user time) by 45% on my Linux box: 1m 50s => 59s BUG=341748 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168611

Patch Set 1 #

Patch Set 2 : Comment tweaks #

Patch Set 3 : Reupload #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -15 lines) Patch
M Source/bindings/generated_bindings.gyp View 5 chunks +33 lines, -2 lines 2 comments Download
M Source/bindings/scripts/blink_idl_parser.py View 1 2 chunks +48 lines, -4 lines 0 comments Download
M Source/bindings/scripts/idl_reader.py View 2 chunks +9 lines, -7 lines 1 comment Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Big speedups! https://codereview.chromium.org/184233005/diff/40001/Source/bindings/scripts/idl_reader.py File Source/bindings/scripts/idl_reader.py (right): https://codereview.chromium.org/184233005/diff/40001/Source/bindings/scripts/idl_reader.py#newcode34 Source/bindings/scripts/idl_reader.py:34: from blink_idl_parser import BlinkIDLParser These are just ...
6 years, 9 months ago (2014-03-05 06:11:50 UTC) #1
haraken
Great improvement. LGTM. (I don't fully understand yacc options, but I believe you understand what ...
6 years, 9 months ago (2014-03-05 06:18:03 UTC) #2
Nils Barth (inactive)
https://codereview.chromium.org/184233005/diff/40001/Source/bindings/generated_bindings.gyp File Source/bindings/generated_bindings.gyp (right): https://codereview.chromium.org/184233005/diff/40001/Source/bindings/generated_bindings.gyp#newcode300 Source/bindings/generated_bindings.gyp:300: '<(bindings_output_dir)/parsetab.pickle', On 2014/03/05 06:18:04, haraken wrote: > parsed_yacc_table.pickle ? ...
6 years, 9 months ago (2014-03-05 06:28:05 UTC) #3
Nils Barth (inactive)
On 2014/03/05 06:18:03, haraken wrote: > Great improvement. LGTM. Thanks! > (I don't fully understand ...
6 years, 9 months ago (2014-03-05 06:29:12 UTC) #4
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-06 08:19:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/184233005/40001
6 years, 9 months ago (2014-03-06 08:19:56 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 09:37:40 UTC) #7
Message was sent while issue was closed.
Change committed as 168611

Powered by Google App Engine
This is Rietveld 408576698