Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1891)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 184233005: Pre-cache PLY yacc parse table and use optimized mode (45% build time improvement) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reupload Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index 72403ef3a11f669104f16e9af1f2791ba131811b..cb9fcd977aec4c01bc26bcac408e2286d9a96c46 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -215,8 +215,9 @@ class BindingsTests(object):
os.path.join(self.output_directory, output_file))
for output_file in os.listdir(self.output_directory)
# Skip cache
- if (output_file != 'parsetab.py' and # PLY cache
- not output_file.endswith('.cache'))] # Jinja cache
+ if not output_file.endswith(('.pickle', # PLY yacc
+ '.cache', # Jinja
+ ))]
return all([self.identical_file(reference_filename, output_filename)
for (reference_filename, output_filename) in file_pairs])
« Source/bindings/scripts/idl_reader.py ('K') | « Source/bindings/scripts/idl_reader.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698