gpu: Use explicit atomics instead of assuming that 32bit read/writes are atomic.

gpu: Use explicit atomics instead of assuming that 32bit read/writes are atomic.

BUG=348324
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255768

[reveman, 2014-03-03 20:09:29]

piman, any idea why base/atomic_ops.h functions were not used for the initial
implementation of queries?

[Dmitry Vyukov, 2014-03-04 08:07:56]

LGTM
thanks

https://codereview.chromium.org/184223003/diff/20001/gpu/command_buffer/commo...
File gpu/command_buffer/common/gles2_cmd_format.h (right):

https://codereview.chromium.org/184223003/diff/20001/gpu/command_buffer/commo...
gpu/command_buffer/common/gles2_cmd_format.h:150: int32 process_count;
s/int32/Atomic32/

[piman, 2014-03-05 21:20:47]

LGTM % other comments.

I suppose historically it had to do with the fact that we couldn't use base/ in
gpu/ (because of nacl).

This is strictly better than before, though ideally we'd take an approach like
in https://codereview.chromium.org/116863003/ where all the atomic operations
are nicely isolated at the lowest level. But LGTM on this for now.

[reveman, 2014-03-06 21:05:42]

https://codereview.chromium.org/184223003/diff/20001/gpu/command_buffer/commo...
File gpu/command_buffer/common/gles2_cmd_format.h (right):

https://codereview.chromium.org/184223003/diff/20001/gpu/command_buffer/commo...
gpu/command_buffer/common/gles2_cmd_format.h:150: int32 process_count;
On 2014/03/04 08:07:56, Dmitry Vyukov wrote:
> s/int32/Atomic32/

Done.

[reveman, 2014-03-06 21:06:06]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-06 21:19:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/184223003/50001

[commit-bot: I haz the power, 2014-03-06 22:08:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/184223003/50001

[commit-bot: I haz the power, 2014-03-06 22:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 22:46:07]

Try jobs failed on following builders: linux_chromium_clang_dbg

[reveman, 2014-03-06 23:17:44]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-06 23:21:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/184223003/70001

[commit-bot: I haz the power, 2014-03-07 01:43:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 01:43:45]

Try jobs failed on following builders: mac_chromium_rel

[reveman, 2014-03-07 03:10:27]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-07 03:14:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/184223003/70001

[commit-bot: I haz the power, 2014-03-07 05:40:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 05:40:09]

Try jobs failed on following builders: mac_chromium_rel

[reveman, 2014-03-07 20:01:12]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-07 20:08:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/184223003/70001

[commit-bot: I haz the power, 2014-03-08 10:43:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/184223003/70001

[commit-bot: I haz the power, 2014-03-08 13:07:49]

Change committed as 255768