gpu/command_buffer/client/gles2_implementation_unittest.cc - Issue 184223003: gpu: Use explicit atomics instead of assuming that 32bit read/writes are atomic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 184223003: gpu: Use explicit atomics instead of assuming that 32bit read/writes are atomic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more s/uint32/base::subtle::Atomic32/ Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/client/gles2_implementation_unittest.cc

diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc

index 843cb91936a809456bb24a9447389426206cf0ae..a2352be17a0afc6357304a7df39773153ac42ae0 100644

--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc

+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc

@@ -2926,7 +2926,7 @@ TEST_F(GLES2ImplementationTest, BeginEndQueryEXT) {

EXPECT_EQ(GL_INVALID_OPERATION, CheckError());

// Test 2nd Begin/End increments count.

- uint32 old_submit_count = query->submit_count();

+ base::subtle::Atomic32 old_submit_count = query->submit_count();

gl_->BeginQueryEXT(GL_ANY_SAMPLES_PASSED_EXT, id1);

EXPECT_NE(old_submit_count, query->submit_count());

expected_end_cmds.end_query.Init(

« no previous file with comments | « no previous file | gpu/command_buffer/client/query_tracker.h » ('j') | no next file with comments »