Shard webcore_dom to avoid MSVS 2 GB limitation

Shard webcore_dom to avoid MSVS 2 GB limitation

A change to tempoarily enable DCHECK on official builds caused
webcore_dom to expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186
Committed: https://crrev.com/529f6f50e463a2469cda86b6363035114264bcbe
Cr-Commit-Position: refs/heads/master@{#384177}

[brucedawson, 2016-03-30 23:00:06]

Description was changed from

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to enable DCHECK on official builds caused webcore_dom to
expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

BUG=599186
==========

to

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to enable DCHECK on official builds caused webcore_dom to
expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

[brucedawson, 2016-03-30 23:00:07]

brucedawson@chromium.org changed reviewers:
+ wez@chromium.org

[brucedawson, 2016-03-30 23:01:03]

Building now - I don't know how long it will take to get results. 15977 targets.

[Wez, 2016-03-30 23:07:23]

lgtm

[dcheng, 2016-03-30 23:17:25]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-03-30 23:17:25]

lgtm

https://codereview.chromium.org/1842203003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/core.gyp (right):

https://codereview.chromium.org/1842203003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/core.gyp:296: 'msvs_shard': 5,
Out of curiosity, why 5?

[esprehn, 2016-03-30 23:23:04]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-03-30 23:23:04]

lgtm, but please note that DCHECK builds are very slow. Blink does a lot of
sanity asserts that walk the entire document repeatedly. Where was shipping
DCHECK builds to real users discussed? Lots of developers use Canary every day
to develop, how do they know when they get a super slow build?

[brucedawson, 2016-03-30 23:30:19]

Description was changed from

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to enable DCHECK on official builds caused webcore_dom to
expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

to

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to enable DCHECK on official builds caused webcore_dom to
expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

[brucedawson, 2016-03-30 23:31:53]

Description was changed from

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to enable DCHECK on official builds caused webcore_dom to
expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

to

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to tempoarily enable DCHECK on official builds caused
webcore_dom to expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

[brucedawson, 2016-03-30 23:32:06]

https://codereview.chromium.org/1842203003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/core.gyp (right):

https://codereview.chromium.org/1842203003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/core.gyp:296: 'msvs_shard': 5,
On 2016/03/30 23:17:25, dcheng wrote:
> Out of curiosity, why 5?

No particular reason - copy/paste with no reason to change it.

Anything from 2 to 200 would probably work equally well, although creating more
than a few sub-libs is messy and adds no value.

[brucedawson, 2016-03-30 23:32:16]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-03-30 23:32:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842203003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842203003/1

[commit-bot: I haz the power, 2016-03-31 01:10:29]

Description was changed from

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to tempoarily enable DCHECK on official builds caused
webcore_dom to expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

to

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to tempoarily enable DCHECK on official builds caused
webcore_dom to expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

[commit-bot: I haz the power, 2016-03-31 01:10:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-31 01:12:48]

Description was changed from

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to tempoarily enable DCHECK on official builds caused
webcore_dom to expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186
==========

to

==========
Shard webcore_dom to avoid MSVS 2 GB limitation

A change to tempoarily enable DCHECK on official builds caused
webcore_dom to expand beyond 2 GB which caused these errors:

  obj\third_party\WebKit\Source\core\webcore_dom.lib : fatal error
  LNK1107: invalid or corrupt file: cannot read at 0x62884508

msvs_shard is a way of breaking up a library to avoid this limitation.

webcore_dom was already at about 2.08 billion bytes, so very close to
the 2 GiB limit, and enabling DCHECK's on official builds pushed it over.

There are no other .lib files which appear to be in danger of hitting
the limit, although I did not check x64 builds.

This change also fixes a repeated spelling error which confused me.

BUG=599186

Committed: https://crrev.com/529f6f50e463a2469cda86b6363035114264bcbe
Cr-Commit-Position: refs/heads/master@{#384177}
==========

[commit-bot: I haz the power, 2016-03-31 01:12:49]

Patchset 1 (id:??) landed as
https://crrev.com/529f6f50e463a2469cda86b6363035114264bcbe
Cr-Commit-Position: refs/heads/master@{#384177}