Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/Source/core/core.gyp

Issue 1842203003: Shard webcore_dom to avoid MSVS 2 GB limitation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/core.gyp
diff --git a/third_party/WebKit/Source/core/core.gyp b/third_party/WebKit/Source/core/core.gyp
index 2c954df34e84a9e1cf5a76ef98539d48f7fed0fd..d9e71e0621dd818903f88bde6d35fdd6df136fd0 100644
--- a/third_party/WebKit/Source/core/core.gyp
+++ b/third_party/WebKit/Source/core/core.gyp
@@ -289,6 +289,13 @@
],
# Disable c4267 warnings until we fix size_t to int truncations.
'msvs_disabled_warnings': [ 4267, ],
+ 'conditions': [
+ # Shard this target into parts to work around linker limitations.
+ # on link time code generation builds. See crbug.com/599186
+ ['OS=="win" and buildtype=="Official"', {
+ 'msvs_shard': 5,
dcheng 2016/03/30 23:17:25 Out of curiosity, why 5?
brucedawson 2016/03/30 23:32:06 No particular reason - copy/paste with no reason t
+ }],
+ ],
},
{
# GN version: //third_party/WebKit/Source/core:html
@@ -301,7 +308,7 @@
'<@(webcore_html_files)',
],
'conditions': [
- # Shard this taret into parts to work around linker limitations.
+ # Shard this target into parts to work around linker limitations.
# on link time code generation builds.
['OS=="win" and buildtype=="Official"', {
'msvs_shard': 5,
@@ -340,7 +347,7 @@
'<@(webcore_rendering_files)',
],
'conditions': [
- # Shard this taret into parts to work around linker limitations.
+ # Shard this target into parts to work around linker limitations.
# on link time code generation builds.
['OS=="win" and buildtype=="Official"', {
'msvs_shard': 5,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698