Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/common/linux/symbol_upload.h

Issue 1842113002: Refactor sym_upload in tools to extract code into common/linux, and minor fixes (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: one more fix indent Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/common/linux/http_upload.cc ('k') | src/common/linux/symbol_upload.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/common/linux/symbol_upload.h
diff --git a/src/processor/pathname_stripper.h b/src/common/linux/symbol_upload.h
similarity index 74%
copy from src/processor/pathname_stripper.h
copy to src/common/linux/symbol_upload.h
index 423ca0d05abc09d6bf0f8ef09ca8ce688d8ac20e..0a469692ac84203f5e5e7d62ddab18a84f37ec07 100644
--- a/src/processor/pathname_stripper.h
+++ b/src/common/linux/symbol_upload.h
@@ -1,4 +1,6 @@
-// Copyright (c) 2006, Google Inc.
+// -*- mode: c++ -*-
+
+// Copyright (c) 2011 Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
@@ -27,27 +29,31 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// pathname_stripper.h: Manipulates pathnames into their component parts.
-//
-// Author: Mark Mentovai
+// symbol_upload.h: helper functions for linux symbol upload tool.
-#ifndef PROCESSOR_PATHNAME_STRIPPER_H__
-#define PROCESSOR_PATHNAME_STRIPPER_H__
+#ifndef COMMON_LINUX_SYMBOL_UPLOAD_H_
+#define COMMON_LINUX_SYMBOL_UPLOAD_H_
#include <string>
#include "common/using_std_string.h"
namespace google_breakpad {
+namespace sym_upload {
+
+typedef struct {
+ string symbolsPath;
+ string uploadURLStr;
+ string proxy;
+ string proxy_user_pwd;
+ string version;
+ bool success;
+} Options;
-class PathnameStripper {
- public:
- // Given path, a pathname with components separated by slashes (/) or
- // backslashes (\), returns the trailing component, without any separator.
- // If path ends in a separator character, returns an empty string.
- static string File(const string &path);
-};
+// Starts upload to symbol server with options.
+void Start(Options* options);
+} // namespace sym_upload
} // namespace google_breakpad
-#endif // PROCESSOR_PATHNAME_STRIPPER_H__
+#endif // COMMON_LINUX_SYMBOL_UPLOAD_H_
« no previous file with comments | « src/common/linux/http_upload.cc ('k') | src/common/linux/symbol_upload.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698