Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: pkg/analysis_server/test/edit/refactoring_test.dart

Issue 1842063003: Start making server strong mode clean (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Remove unintended change Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/edit/refactoring_test.dart
diff --git a/pkg/analysis_server/test/edit/refactoring_test.dart b/pkg/analysis_server/test/edit/refactoring_test.dart
index 54a4e1179219dab2fa52bc7891c0711181314fbc..7c9223afb4e7588562911eb6f83ab36ffdd95bb0 100644
--- a/pkg/analysis_server/test/edit/refactoring_test.dart
+++ b/pkg/analysis_server/test/edit/refactoring_test.dart
@@ -653,11 +653,10 @@ void res(int a, int b) {
''');
}
- Future<Response> _computeChange() {
- return _prepareOptions().then((_) {
- // send request with the options
- return _sendExtractRequest();
- });
+ Future<Response> _computeChange() async {
+ await _prepareOptions();
+ // send request with the options
+ return _sendExtractRequest();
}
Future<ExtractMethodFeedback> _computeInitialFeedback() {
@@ -1867,12 +1866,10 @@ class _AbstractGetRefactoring_Test extends AbstractAnalysisTest {
}
Future<EditGetRefactoringResult> getRefactoringResult(
- Future<Response> requestSender()) {
- return waitForTasksFinished().then((_) {
- return requestSender().then((Response response) {
- return new EditGetRefactoringResult.fromResponse(response);
- });
- });
+ Future<Response> requestSender()) async {
+ await waitForTasksFinished();
+ Response response = await requestSender();
+ return new EditGetRefactoringResult.fromResponse(response);
}
Future<Response> sendRequest(

Powered by Google App Engine
This is Rietveld 408576698