Add *IndexSetIfNull methods to SemanticSendVisitor.

Add *IndexSetIfNull methods to SemanticSendVisitor.

R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/46beb25f43018b2b6ed036b7b0d68e600990ea7f

[Johnni Winther, 2016-03-31 14:06:30]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com, sigurdm@google.com

[Johnni Winther, 2016-03-31 14:06:31]

sigmund@: PTAL a look at the StatsVisitor.

[sigurdm, 2016-03-31 14:38:57]

LGTM

Do the language tests cover this well enough?

[Siggi Cherem (dart-lang), 2016-03-31 16:42:19]

dbc

https://codereview.chromium.org/1842033004/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1842033004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:3322: ///     class B {
add operator[]=(index)? (otherwise the example is the same as
UnresolvedSuperIndexSetIfNull)

https://codereview.chromium.org/1842033004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:3345: ///       m() =>
super[1] += 42;
s/+=/??=/

[Johnni Winther, 2016-04-01 07:32:11]

On 2016/03/31 14:38:57, sigurdm wrote:
> LGTM
> 
> Do the language tests cover this well enough?

Yes, fortunately :)

[Johnni Winther, 2016-04-01 07:32:58]

https://codereview.chromium.org/1842033004/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1842033004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:3322: ///     class B {
On 2016/03/31 16:42:19, Siggi Cherem (dart-lang) wrote:
> add operator[]=(index)? (otherwise the example is the same as
> UnresolvedSuperIndexSetIfNull)

Done.

https://codereview.chromium.org/1842033004/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:3345: ///       m() =>
super[1] += 42;
On 2016/03/31 16:42:19, Siggi Cherem (dart-lang) wrote:
> s/+=/??=/

Done.

[Johnni Winther, 2016-04-01 07:46:51]

Description was changed from

==========
Add *IndexSetIfNull methods to SemanticSendVisitor.
==========

to

==========
Add *IndexSetIfNull methods to SemanticSendVisitor.

R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/46beb25f43018b2b6ed036b7b0d68e600990ea7f
==========

[Johnni Winther, 2016-04-01 07:46:52]

Committed patchset #2 (id:20001) manually as
46beb25f43018b2b6ed036b7b0d68e600990ea7f (presubmit successful).