Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1842033004: Add *IndexSetIfNull methods to SemanticSendVisitor. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 8c8f78c5e171a76f809138a700f6ea1714154201..ad5905ddec5d361ca15ca2d70bd0a062bf236dea 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -1037,6 +1037,7 @@ class SwitchCaseJumpHandler extends TargetJumpHandler {
class SsaBuilder extends ast.Visitor
with BaseImplementationOfCompoundsMixin,
BaseImplementationOfSetIfNullsMixin,
+ BaseImplementationOfSuperIndexSetIfNullMixin,
SemanticSendResolvedMixin,
NewBulkMixin,
ErrorBulkMixin
@@ -7108,6 +7109,32 @@ class SsaBuilder extends ast.Visitor
}
@override
+ handleSuperIndexSetIfNull(
+ ast.SendSet node,
+ Element indexFunction,
+ Element indexSetFunction,
+ ast.Node index,
+ ast.Node rhs,
+ arg,
+ {bool isGetterValid,
+ bool isSetterValid}) {
+ handleCompoundSendSet(node);
+ }
+
+ @override
+ visitIndexSetIfNull(
+ ast.SendSet node,
+ ast.Node receiver,
+ ast.Node index,
+ ast.Node rhs,
+ arg,
+ {bool isGetterValid,
+ bool isSetterValid}) {
+ generateIsDeferredLoadedCheckOfSend(node);
+ handleIndexSendSet(node);
+ }
+
+ @override
handleTypeLiteralConstantSetIfNulls(
ast.SendSet node,
ConstantExpression constant,
« no previous file with comments | « pkg/compiler/lib/src/resolution/send_structure.dart ('k') | tests/compiler/dart2js/semantic_visitor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698