Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1842003002: [arm/Linux] Don't rely on KUSER_HELPERS feature (Closed)

Created:
4 years, 8 months ago by jbriance
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[arm/Linux] Don't rely on KUSER_HELPERS feature ARM specific CONFIG_KUSER_HELPERS kernel feature for Linux can be disabled, and in this case, we shouldn't crash. Use a __sync_synchronize() call instead for Linux platforms. BUG=599051 Committed: https://crrev.com/d65c3c2511404c3c5a5a5f304eb3b83ac5194e7a Cr-Commit-Position: refs/heads/master@{#383967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/Atomics.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jbriance
4 years, 8 months ago (2016-03-30 12:26:15 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-03-30 12:27:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842003002/1
4 years, 8 months ago (2016-03-30 12:33:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 13:42:22 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 13:44:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d65c3c2511404c3c5a5a5f304eb3b83ac5194e7a
Cr-Commit-Position: refs/heads/master@{#383967}

Powered by Google App Engine
This is Rietveld 408576698