Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html

Issue 1841863003: DevTools: move the force update SW on reload checkbox to the Resources / Service Workers view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fixed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
index ab6f032305ccf2efce255b3f61a5ff1b896763d3..92da6e9edb1751e4976aaeff4c27bea4d257bc27 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
@@ -65,10 +65,7 @@ function test()
.then(function() {
InspectorTest.addResult("The second frame loaded.");
InspectorTest.addResult("Check \"Force update on page load\" check box");
- WebInspector.panels.sources.sidebarPanes.serviceWorkers.expand();
- for (var element of WebInspector.panels.sources.sidebarPanes.serviceWorkers._versionIdCheckBoxMap.values()) {
- element.click();
- }
+ WebInspector.settings.settingForTest("serviceWorkerUpdateOnReload").set(true);
return InspectorTest.invokePageFunctionPromise("loadIframe", [scope]);
})
.then(function() {
@@ -78,9 +75,7 @@ function test()
.then(function() {
InspectorTest.addResult("The fourth frame loaded. The third worker must be activated before here.");
InspectorTest.addResult("Uncheck \"Force update on page load\" check box");
- for (var element of WebInspector.panels.sources.sidebarPanes.serviceWorkers._versionIdCheckBoxMap.values()) {
- element.click();
- }
+ WebInspector.settings.settingForTest("serviceWorkerUpdateOnReload").set(false);
return InspectorTest.invokePageFunctionPromise("loadIframe", [scope]);
})
.then(function() {
« no previous file with comments | « content/browser/service_worker/service_worker_registration.cc ('k') | third_party/WebKit/Source/devtools/devtools.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698