content/browser/service_worker/service_worker_registration.cc - Issue 1841863003: DevTools: move the force update SW on reload checkbox to the Resources / Service Workers view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 1841863003: DevTools: move the force update SW on reload checkbox to the Resources / Service Workers view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test fixed Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration.h ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index d24c8c936108163f0ed77e733eb39c4ed92ff785..90aa7ffed3c18be1bc3b7158eb51708e93cb7044 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -36,7 +36,6 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(

is_uninstalling_(false),

is_uninstalled_(false),

should_activate_when_ready_(false),

- force_update_on_page_load_(false),

resources_total_size_bytes_(0),

context_(context) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

@@ -93,8 +92,6 @@ ServiceWorkerRegistrationInfo ServiceWorkerRegistration::GetInfo() {

pattern(), registration_id_,

is_deleted_ ? ServiceWorkerRegistrationInfo::IS_DELETED

: ServiceWorkerRegistrationInfo::IS_NOT_DELETED,

- force_update_on_page_load_ ? ServiceWorkerRegistrationInfo::IS_FORCED

- : ServiceWorkerRegistrationInfo::IS_NOT_FORCED,

GetVersionInfo(active_version_.get()),

GetVersionInfo(waiting_version_.get()),

GetVersionInfo(installing_version_.get()), resources_total_size_bytes_);