Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 1841863002: Update monet. (Closed) Base URL: https://github.com/domokit/monet.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.flags ('k') | tools/clang/scripts/blink_gc_plugin_flags.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/overridden_methods.txt
diff --git a/tools/clang/plugins/tests/overridden_methods.txt b/tools/clang/plugins/tests/overridden_methods.txt
index bc2d1aca86a9dde33bf5ec1d8762d20efde1472e..037d4348bc00fb054cb18da7c4d55d6fc87f5ce1 100644
--- a/tools/clang/plugins/tests/overridden_methods.txt
+++ b/tools/clang/plugins/tests/overridden_methods.txt
@@ -3,6 +3,10 @@ In file included from overridden_methods.cpp:5:
virtual void SomeMethod() = 0;
^
override
+./overridden_methods.h:38:42: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual void WebKitModifiedSomething() {};
+ ^
+ override
./overridden_methods.h:46:27: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
virtual ~DerivedClass() {}
^
@@ -15,6 +19,10 @@ In file included from overridden_methods.cpp:5:
virtual void SomeInlineMethod() {}
^
override
+./overridden_methods.h:54:41: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual void WebKitModifiedSomething();
+ ^
+ override
./overridden_methods.h:56:40: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
virtual void SomeConstMethod() const {}
^
@@ -55,6 +63,10 @@ overridden_methods.cpp:28:35: warning: [chromium-style] Overriding method must b
virtual void SomeInlineMethod() {}
^
override
+overridden_methods.cpp:30:41: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual void WebKitModifiedSomething();
+ ^
+ override
overridden_methods.cpp:32:40: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
virtual void SomeConstMethod() const {}
^
@@ -79,4 +91,4 @@ overridden_methods.cpp:43:47: warning: [chromium-style] Overriding method must b
virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
^
override
-20 warnings generated.
+23 warnings generated.
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.flags ('k') | tools/clang/scripts/blink_gc_plugin_flags.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698