Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 1841863002: Update monet. (Closed) Base URL: https://github.com/domokit/monet.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.flags ('k') | tools/clang/scripts/blink_gc_plugin_flags.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from overridden_methods.cpp:5: 1 In file included from overridden_methods.cpp:5:
2 ./overridden_methods.h:25:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 2 ./overridden_methods.h:25:29: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
3 virtual void SomeMethod() = 0; 3 virtual void SomeMethod() = 0;
4 ^ 4 ^
5 override 5 override
6 ./overridden_methods.h:38:42: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual void WebKitModifiedSomething() {};
8 ^
9 override
6 ./overridden_methods.h:46:27: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 10 ./overridden_methods.h:46:27: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual ~DerivedClass() {} 11 virtual ~DerivedClass() {}
8 ^ 12 ^
9 override 13 override
10 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 14 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
11 virtual void SomeMethod(); 15 virtual void SomeMethod();
12 ^ 16 ^
13 override 17 override
14 ./overridden_methods.h:52:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 18 ./overridden_methods.h:52:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
15 virtual void SomeInlineMethod() {} 19 virtual void SomeInlineMethod() {}
16 ^ 20 ^
17 override 21 override
22 ./overridden_methods.h:54:41: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
23 virtual void WebKitModifiedSomething();
24 ^
25 override
18 ./overridden_methods.h:56:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 26 ./overridden_methods.h:56:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
19 virtual void SomeConstMethod() const {} 27 virtual void SomeConstMethod() const {}
20 ^ 28 ^
21 override 29 override
22 ./overridden_methods.h:58:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 30 ./overridden_methods.h:58:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
23 virtual void SomeMethodWithExceptionSpec() throw() {} 31 virtual void SomeMethodWithExceptionSpec() throw() {}
24 ^ 32 ^
25 override 33 override
26 ./overridden_methods.h:61:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 34 ./overridden_methods.h:61:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
27 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {} 35 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}
(...skipping 20 matching lines...) Expand all
48 ^ 56 ^
49 override 57 override
50 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 58 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
51 virtual void SomeMethod(); 59 virtual void SomeMethod();
52 ^ 60 ^
53 override 61 override
54 overridden_methods.cpp:28:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 62 overridden_methods.cpp:28:35: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
55 virtual void SomeInlineMethod() {} 63 virtual void SomeInlineMethod() {}
56 ^ 64 ^
57 override 65 override
66 overridden_methods.cpp:30:41: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
67 virtual void WebKitModifiedSomething();
68 ^
69 override
58 overridden_methods.cpp:32:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 70 overridden_methods.cpp:32:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
59 virtual void SomeConstMethod() const {} 71 virtual void SomeConstMethod() const {}
60 ^ 72 ^
61 override 73 override
62 overridden_methods.cpp:34:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 74 overridden_methods.cpp:34:54: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
63 virtual void SomeMethodWithExceptionSpec() throw() {} 75 virtual void SomeMethodWithExceptionSpec() throw() {}
64 ^ 76 ^
65 override 77 override
66 overridden_methods.cpp:37:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 78 overridden_methods.cpp:37:68: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
67 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {} 79 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}
68 ^ 80 ^
69 override 81 override
70 overridden_methods.cpp:39:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 82 overridden_methods.cpp:39:40: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
71 virtual void SomeNonPureBaseMethod() {} 83 virtual void SomeNonPureBaseMethod() {}
72 ^ 84 ^
73 override 85 override
74 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 86 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
75 virtual void SomeMethodWithComment(); // This is a comment. 87 virtual void SomeMethodWithComment(); // This is a comment.
76 ^ 88 ^
77 override 89 override
78 overridden_methods.cpp:43:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 90 overridden_methods.cpp:43:47: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
79 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 91 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
80 ^ 92 ^
81 override 93 override
82 20 warnings generated. 94 23 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/overridden_methods.flags ('k') | tools/clang/scripts/blink_gc_plugin_flags.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698