third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp ('K') | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | third_party/WebKit/Source/platform/exported/WebFont.cpp » ('j') | third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp

index a32427a80f3fbbdebace7b7dad42e1bec109884c..57cf9fc3e277cc960759b5fb59daaf13d5ca1b6b 100644

--- a/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp

@@ -178,6 +178,8 @@ PassRefPtr<SkImageFilter> FEImage::createImageFilterForLayoutObject(const Layout

SVGPaintContext::paintSubtree(filterPicture.context(), &layoutObject);

}

RefPtr<const SkPicture> recording = filterPicture.endRecording();

+ if (!recording)

+ return nullptr;

chrishtr 2016/03/29 22:42:23 ditto

wkorman 2016/03/29 22:52:02 Yes.

RefPtr<SkImageFilter> result = adoptRef(SkPictureImageFilter::Create(recording.get(), dstRect));

return result.release();