third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h ('k') | third_party/WebKit/Source/core/paint/SVGClipPainter.cpp » ('j') | third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

index 386da9e10da92e1fb7f6ff82bb5c1e140c1e40cb..801ecd679595873fabf4a2457e7f15c4fa251f9a 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp

@@ -109,8 +109,12 @@ PassOwnPtr<PatternData> LayoutSVGResourcePattern::buildPatternData(const LayoutO

tileTransform.scale(clientBoundingBox.width(), clientBoundingBox.height());

}

+ RefPtr<SkPicture> recording = asPicture(tileBounds, tileTransform);

+ if (!recording)

+ return nullptr;

chrishtr 2016/03/29 22:42:23 Callsites are robust against this?

wkorman 2016/03/29 22:52:02 Yes.

OwnPtr<PatternData> patternData = adoptPtr(new PatternData);

- patternData->pattern = Pattern::createPicturePattern(asPicture(tileBounds, tileTransform));

+ patternData->pattern = Pattern::createPicturePattern(recording);

// Compute pattern space transformation.

patternData->transform.translate(tileBounds.x(), tileBounds.y());