Revert of Popup loosing focus through keyboard events should update HTMLSelectElement display

Revert of Popup loosing focus through keyboard events should update HTMLSelectElement display (patchset #3 id:40001 of https://codereview.chromium.org/1833843002/ )

Reason for revert:
Caused crashes; crbug.com/598291

Original issue's description:
> Popup loosing focus through keyboard events should update HTMLSelectElement display
>
> Ctrl-N while a popup menu is open, causes the window to loose focus, and ViewMsg_Close is sent to the popup widget.
> This causes WebPagePopupImpl::close to be called.
> Right now this causes the popup to close without updating the display from the provisional selection (ie HTMLSelectElement::indexToSelectOnCancel) to the actual selection.
> WebPagePopupImpl::close should use WebPagePopupImpl::cancel to handle that case properly.
>
> Loosing focus through mouse clicks were working because we manually call cancel from the mouse event handler.
>
> Regression caused by r193034
>
> BUG=597206
>
> Committed: https://crrev.com/831776ec4a98f781dc8ce20bb3346538fd59b8da
> Cr-Commit-Position: refs/heads/master@{#383271}

TBR=keishi@chromium.org
NOTRY=true
BUG=597206, 598291
Committed: https://crrev.com/3223d00c477336a4a6d8af18dfc5fe24591e156d
Cr-Commit-Position: refs/heads/master@{#383614}

[tkent, 2016-03-28 23:46:28]

Created Revert of Popup loosing focus through keyboard events should update
HTMLSelectElement display

[tkent, 2016-03-28 23:46:59]

Description was changed from

==========
Revert of Popup loosing focus through keyboard events should update
HTMLSelectElement display (patchset #3 id:40001 of
https://codereview.chromium.org/1833843002/ )

Reason for revert:
Caused crashes; crbug.com/598291


Original issue's description:
> Popup loosing focus through keyboard events should update HTMLSelectElement
display
> 
> Ctrl-N while a popup menu is open, causes the window to loose focus, and
ViewMsg_Close is sent to the popup widget.
> This causes WebPagePopupImpl::close to be called.
> Right now this causes the popup to close without updating the display from the
provisional selection (ie HTMLSelectElement::indexToSelectOnCancel) to the
actual selection.
> WebPagePopupImpl::close should use WebPagePopupImpl::cancel to handle that
case properly.
> 
> Loosing focus through mouse clicks were working because we manually call
cancel from the mouse event handler.
> 
> Regression caused by r193034
> 
> BUG=597206
> 
> Committed: https://crrev.com/831776ec4a98f781dc8ce20bb3346538fd59b8da
> Cr-Commit-Position: refs/heads/master@{#383271}

TBR=keishi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597206
==========

to

==========
Revert of Popup loosing focus through keyboard events should update
HTMLSelectElement display (patchset #3 id:40001 of
https://codereview.chromium.org/1833843002/ )

Reason for revert:
Caused crashes; crbug.com/598291


Original issue's description:
> Popup loosing focus through keyboard events should update HTMLSelectElement
display
> 
> Ctrl-N while a popup menu is open, causes the window to loose focus, and
ViewMsg_Close is sent to the popup widget.
> This causes WebPagePopupImpl::close to be called.
> Right now this causes the popup to close without updating the display from the
provisional selection (ie HTMLSelectElement::indexToSelectOnCancel) to the
actual selection.
> WebPagePopupImpl::close should use WebPagePopupImpl::cancel to handle that
case properly.
> 
> Loosing focus through mouse clicks were working because we manually call
cancel from the mouse event handler.
> 
> Regression caused by r193034
> 
> BUG=597206
> 
> Committed: https://crrev.com/831776ec4a98f781dc8ce20bb3346538fd59b8da
> Cr-Commit-Position: refs/heads/master@{#383271}

TBR=keishi@chromium.org
NOTRY=true
BUG=597206, 598291
==========

[tkent, 2016-03-28 23:47:04]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-03-28 23:47:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841623002/1

[commit-bot: I haz the power, 2016-03-28 23:52:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-28 23:54:07]

Description was changed from

==========
Revert of Popup loosing focus through keyboard events should update
HTMLSelectElement display (patchset #3 id:40001 of
https://codereview.chromium.org/1833843002/ )

Reason for revert:
Caused crashes; crbug.com/598291


Original issue's description:
> Popup loosing focus through keyboard events should update HTMLSelectElement
display
> 
> Ctrl-N while a popup menu is open, causes the window to loose focus, and
ViewMsg_Close is sent to the popup widget.
> This causes WebPagePopupImpl::close to be called.
> Right now this causes the popup to close without updating the display from the
provisional selection (ie HTMLSelectElement::indexToSelectOnCancel) to the
actual selection.
> WebPagePopupImpl::close should use WebPagePopupImpl::cancel to handle that
case properly.
> 
> Loosing focus through mouse clicks were working because we manually call
cancel from the mouse event handler.
> 
> Regression caused by r193034
> 
> BUG=597206
> 
> Committed: https://crrev.com/831776ec4a98f781dc8ce20bb3346538fd59b8da
> Cr-Commit-Position: refs/heads/master@{#383271}

TBR=keishi@chromium.org
NOTRY=true
BUG=597206, 598291
==========

to

==========
Revert of Popup loosing focus through keyboard events should update
HTMLSelectElement display (patchset #3 id:40001 of
https://codereview.chromium.org/1833843002/ )

Reason for revert:
Caused crashes; crbug.com/598291

Original issue's description:
> Popup loosing focus through keyboard events should update HTMLSelectElement
display
>
> Ctrl-N while a popup menu is open, causes the window to loose focus, and
ViewMsg_Close is sent to the popup widget.
> This causes WebPagePopupImpl::close to be called.
> Right now this causes the popup to close without updating the display from the
provisional selection (ie HTMLSelectElement::indexToSelectOnCancel) to the
actual selection.
> WebPagePopupImpl::close should use WebPagePopupImpl::cancel to handle that
case properly.
>
> Loosing focus through mouse clicks were working because we manually call
cancel from the mouse event handler.
>
> Regression caused by r193034
>
> BUG=597206
>
> Committed: https://crrev.com/831776ec4a98f781dc8ce20bb3346538fd59b8da
> Cr-Commit-Position: refs/heads/master@{#383271}

TBR=keishi@chromium.org
NOTRY=true
BUG=597206, 598291

Committed: https://crrev.com/3223d00c477336a4a6d8af18dfc5fe24591e156d
Cr-Commit-Position: refs/heads/master@{#383614}
==========

[commit-bot: I haz the power, 2016-03-28 23:54:07]

Patchset 1 (id:??) landed as
https://crrev.com/3223d00c477336a4a6d8af18dfc5fe24591e156d
Cr-Commit-Position: refs/heads/master@{#383614}