Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1841623002: Revert of Popup loosing focus through keyboard events should update HTMLSelectElement display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 44e0710891781a0ba00d0fe86aa91a3d015cfcef..74dce75d81f37924a8a8d4aa38c8674d1dddcc91 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -489,10 +489,14 @@
void WebPagePopupImpl::close()
{
+ m_closing = true;
+ // In case closePopup() was not called.
+ if (m_page) {
+ destroyPage();
+ m_popupClient->didClosePopup();
+ m_webView->cleanupPagePopup();
+ }
m_widgetClient = 0;
- // In case closePopup() was not called.
- if (m_page)
- cancel();
deref();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698