tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout - Issue 18416005: rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir

Unified Diff: tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout

Issue 18416005: rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: add_test_to_exercise_bad_dir_warning Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/tests/rebaseline/output/exercise-bug1403/output-expected/return_value ('k') | tools/tests/rebaseline/output/subset/output-expected/command_line » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout

===================================================================

--- tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout (revision 0)

+++ tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout (revision 0)

@@ -0,0 +1,6 @@

+Traceback (most recent call last):

+ File "tools/rebaseline.py", line 288, in <module>

+ rebaseliner.RebaselineSubdir(subdir=subdir, builder=builder)

+ File "/usr/local/google/home/epoger/src/skia/white/trunk/tools/rebaseline_imagefiles.py", line 260, in RebaselineSubdir

+ 'gm-expected directory?') % (subdir, self._expectations_root))

+Exception: Could not find "base-android-galaxy-nexus" subdir within expectations_root "tools/tests/rebaseline/input". Are you sure --expectations-root is pointing at a valid gm-expected directory?

epoger 2013/07/10 16:28:39 Since this test case sets --expecations-root to a

Stephen White 2013/07/10 16:47:36 More a design question, but should we actually be

epoger 2013/07/10 16:53:34 Advantages of printing the stack trace: - gives yo

epoger 2013/07/10 17:14:27 Disadvantage of printing the stack trace: the stac