tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout - Issue 18416005: rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir

Side by Side Diff: tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout

Issue 18416005: rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: add_test_to_exercise_bad_dir_warning Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/tests/rebaseline/output/exercise-bug1403/output-expected/return_value ('k') | tools/tests/rebaseline/output/subset/output-expected/command_line » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Traceback (most recent call last):

	2 File "tools/rebaseline.py", line 288, in <module>

	3 rebaseliner.RebaselineSubdir(subdir=subdir, builder=builder)

	4 File "/usr/local/google/home/epoger/src/skia/white/trunk/tools/rebaseline_imag efiles.py", line 260, in RebaselineSubdir

	5 'gm-expected directory?') % (subdir, self._expectations_root))

	6 Exception: Could not find "base-android-galaxy-nexus" subdir within expectations _root "tools/tests/rebaseline/input". Are you sure --expectations-root is point ing at a valid gm-expected directory?
	epoger 2013/07/10 16:28:39 Since this test case sets --expecations-root to a Since this test case sets --expecations-root to a directory without the expected platform subdirs, it fails right away with a helpful error message. Stephen White 2013/07/10 16:47:36 More a design question, but should we actually be Show quoted text On 2013/07/10 16:28:39, epoger wrote: > Since this test case sets --expecations-root to a directory without the expected > platform subdirs, it fails right away with a helpful error message. More a design question, but should we actually be providing tracebacks in this case, or just catching the exception at the top level and printing an error message? epoger 2013/07/10 16:53:34 Advantages of printing the stack trace: - gives yo Show quoted text On 2013/07/10 16:47:36, Stephen White wrote: > On 2013/07/10 16:28:39, epoger wrote: > > Since this test case sets --expecations-root to a directory without the > expected > > platform subdirs, it fails right away with a helpful error message. > > More a design question, but should we actually be providing tracebacks in this > case, or just catching the exception at the top level and printing an error > message? Advantages of printing the stack trace: - gives you more info Disadvantages: - would be confusing to mortals (but woe be to mortals running rebaseline.py) - more output that changes in the tool self-tests I think I'll leave it as-is for now, but I wouldn't be opposed to changing it. epoger 2013/07/10 17:14:27 Disadvantage of printing the stack trace: the stac Show quoted text On 2013/07/10 16:53:34, epoger wrote: > On 2013/07/10 16:47:36, Stephen White wrote: > > On 2013/07/10 16:28:39, epoger wrote: > > > Since this test case sets --expecations-root to a directory without the > > expected > > > platform subdirs, it fails right away with a helpful error message. > > > > More a design question, but should we actually be providing tracebacks in this > > case, or just catching the exception at the top level and printing an error > > message? > > Advantages of printing the stack trace: > - gives you more info > > Disadvantages: > - would be confusing to mortals (but woe be to mortals running rebaseline.py) > - more output that changes in the tool self-tests > > I think I'll leave it as-is for now, but I wouldn't be opposed to changing it. Disadvantage of printing the stack trace: the stack trace shows up differently on the bot, so this CL broke the Housekeeper-PerCommit build. http://108.170.217.252:10117/builders/Housekeeper-PerCommit/builds/752/steps/... I'll change it to just print out the error message, not the whole stack trace. :-)
OLD	NEW