Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tools/rebaseline.py

Issue 18416005: rebaseline.py: error out early if --expectations-root not pointing at gm-expected dir (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: add_test_to_exercise_bad_dir_warning Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/rebaseline.py
===================================================================
--- tools/rebaseline.py (revision 9956)
+++ tools/rebaseline.py (working copy)
@@ -188,11 +188,7 @@
# Write out updated expectations.
gm_json.WriteToFile(expectations_dict, expectations_json_filepath)
- if skipped_images:
- print ('Skipped these tests due to test/config filters: %s' %
- skipped_images)
-
# main...
parser = argparse.ArgumentParser()
@@ -275,6 +271,12 @@
actuals_filename=args.actuals_filename,
add_new=args.add_new)
else:
+ # TODO(epoger): When we get rid of the ImageRebaseliner implementation,
+ # we should raise an Exception in this case (no JSON expectations file
+ # found to update), to prevent a recurrence of
+ # https://code.google.com/p/skia/issues/detail?id=1403 ('rebaseline.py
+ # script fails with misleading output when run outside of gm-expected
+ # dir')
rebaseliner = rebaseline_imagefiles.ImageRebaseliner(
expectations_root=args.expectations_root,
tests=args.tests, configs=args.configs,
« no previous file with comments | « no previous file | tools/rebaseline_imagefiles.py » ('j') | tools/tests/rebaseline/output/exercise-bug1403/output-expected/stdout » ('J')

Powered by Google App Engine
This is Rietveld 408576698