[Chrome ELF] New NT registry API.

chrome_elf/breakpad.h

Index: chrome_elf/breakpad.h
diff --git a/chrome_elf/breakpad.h b/chrome_elf/breakpad.h
deleted file mode 100644
index 8067708b6479eb179e75c78e89df915df08af626..0000000000000000000000000000000000000000
--- a/chrome_elf/breakpad.h
+++ /dev/null
@@ -1,34 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-

[robertshield, 2016/06/23 02:29:36]

Why is this file moved in this CL? If intentional, please update CL description,
but it seems like this should be done in a separate CL.

[penny, 2016/06/25 21:13:43]

Yes.  I've updated the CL description with a mention.  I mentioned the rename in
my previous comments on this review:

This changelist looks much bigger than it actually is, due to some renames.

- hook_util static lib now holds the little thunk code.
- nt_registry now holds the new ntdll api.
- chrome/install_static/install_util now holds what used to be chrome_elf_util
-> which Ananta changed in prep
for switching breakpad to crashpad in chrome_elf.
- breakpad now in subdirectory.
- removed "common" build target.  everything organized now.

I hear you and appreciate your comments about the size of this CL.  Some of the
bloating came from trying to handle the clashing with concurrent changes to
slowly add crashpad.  At this point, I plan to land this CL as is.

There should have been better communications about efforts to touch the same
code for different work (at the same time).  I will work to ensure I don't end
up reacting to multiple clashes again in the future - it's definitely not
efficient.

-#ifndef CHROME_ELF_BREAKPAD_H_
-#define CHROME_ELF_BREAKPAD_H_
-
-#include <windows.h>
-
-namespace google_breakpad {
-class ExceptionHandler;
-}
-
-// Initializes collection and upload of crash reports. This will only be done if
-// the user has agreed to crash dump reporting.
-//
-// Crash reporting has to be initialized as early as possible (e.g., the first
-// thing in main()) to catch crashes occuring during process startup.
-// Crashes which occur during the global static construction phase will not
-// be caught and reported. This should not be a problem as static non-POD
-// objects are not allowed by the style guide and exceptions to this rule are
-// rare.
-void InitializeCrashReporting();
-
-// Generates a crashdump for the provided |exinfo|. This crashdump will be
-// either be saved locally, or uploaded, depending on how the ExceptionHandler
-// has been configured.
-int GenerateCrashDump(EXCEPTION_POINTERS* exinfo);
-
-// Global pointer to the ExceptionHandler. This is initialized by
-// InitializeCrashReporting() and used by GenerateCrashDump() to record dumps.
-extern google_breakpad::ExceptionHandler* g_elf_breakpad;
-
-#endif  // CHROME_ELF_BREAKPAD_H_