chrome_elf/breakpad.h - Issue 1841573002: [Chrome ELF] New NT registry API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_elf/breakpad.h

Issue 1841573002: [Chrome ELF] New NT registry API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit fixes & CreateRegKey now recursive. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4
robertshield 2016/06/23 02:29:36 Why is this file moved in this CL? If intentional, Why is this file moved in this CL? If intentional, please update CL description, but it seems like this should be done in a separate CL. penny 2016/06/25 21:13:43 Yes. I've updated the CL description with a menti Show quoted text On 2016/06/23 02:29:36, robertshield wrote: > Why is this file moved in this CL? If intentional, please update CL description, > but it seems like this should be done in a separate CL. Yes. I've updated the CL description with a mention. I mentioned the rename in my previous comments on this review: This changelist looks much bigger than it actually is, due to some renames. - hook_util static lib now holds the little thunk code. - nt_registry now holds the new ntdll api. - chrome/install_static/install_util now holds what used to be chrome_elf_util -> which Ananta changed in prep for switching breakpad to crashpad in chrome_elf. - breakpad now in subdirectory. - removed "common" build target. everything organized now. I hear you and appreciate your comments about the size of this CL. Some of the bloating came from trying to handle the clashing with concurrent changes to slowly add crashpad. At this point, I plan to land this CL as is. There should have been better communications about efforts to touch the same code for different work (at the same time). I will work to ensure I don't end up reacting to multiple clashes again in the future - it's definitely not efficient.
5 #ifndef CHROME_ELF_BREAKPAD_H_

6 #define CHROME_ELF_BREAKPAD_H_

7

8 #include <windows.h>

9

10 namespace google_breakpad {

11 class ExceptionHandler;

12 }

13

14 // Initializes collection and upload of crash reports. This will only be done if

15 // the user has agreed to crash dump reporting.

16 //

17 // Crash reporting has to be initialized as early as possible (e.g., the first

18 // thing in main()) to catch crashes occuring during process startup.

19 // Crashes which occur during the global static construction phase will not

20 // be caught and reported. This should not be a problem as static non-POD

21 // objects are not allowed by the style guide and exceptions to this rule are

22 // rare.

23 void InitializeCrashReporting();

24

25 // Generates a crashdump for the provided \|exinfo\|. This crashdump will be

26 // either be saved locally, or uploaded, depending on how the ExceptionHandler

27 // has been configured.

28 int GenerateCrashDump(EXCEPTION_POINTERS* exinfo);

29

30 // Global pointer to the ExceptionHandler. This is initialized by

31 // InitializeCrashReporting() and used by GenerateCrashDump() to record dumps.

32 extern google_breakpad::ExceptionHandler* g_elf_breakpad;

33

34 #endif // CHROME_ELF_BREAKPAD_H_

OLD	NEW

« no previous file with comments | « chrome_elf/blacklist/test/blacklist_test_main_dll.def ('k') | chrome_elf/breakpad.cc » ('j') | chrome_elf/nt_registry/nt_registry.cc » ('J')