Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1841543002: [Extensions] Convert APIs to use movable types [12] (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert APIs to use movable types [12] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - management.json - mime_handler_private.idl - mojo_private.idl - networking_config.idl - networking_private.idl - power.idl - printer_provider.idl - printer_provider_internal.idl - runtime.json BUG=595949 Committed: https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298 Cr-Commit-Position: refs/heads/master@{#383832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -82 lines) Patch
M extensions/browser/api/management/management_api.cc View 9 chunks +56 lines, -63 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_api.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M extensions/browser/api/printer_provider/printer_provider_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/api/management.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/mime_handler_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/mojo_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/networking_config.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/networking_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/power.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/printer_provider.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/printer_provider_internal.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/runtime.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Devlin
4 years, 8 months ago (2016-03-29 14:37:45 UTC) #3
lazyboy
lgtm.
4 years, 8 months ago (2016-03-29 19:08:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841543002/1
4 years, 8 months ago (2016-03-29 21:23:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 21:33:11 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:34:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d993d51b92d973c55e30b32711942861adfaa298
Cr-Commit-Position: refs/heads/master@{#383832}

Powered by Google App Engine
This is Rietveld 408576698