Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: extensions/browser/api/networking_config/networking_config_api.cc

Issue 1841543002: [Extensions] Convert APIs to use movable types [12] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/networking_config/networking_config_api.cc
diff --git a/extensions/browser/api/networking_config/networking_config_api.cc b/extensions/browser/api/networking_config/networking_config_api.cc
index 57722537e395bb5bcbac9fb39691ae3b31b9476f..581e0d8b59a6378ac89dedc998aa5356cb3761ba 100644
--- a/extensions/browser/api/networking_config/networking_config_api.cc
+++ b/extensions/browser/api/networking_config/networking_config_api.cc
@@ -42,23 +42,22 @@ NetworkingConfigSetNetworkFilterFunction::Run() {
// Remove previously registered networks.
service->UnregisterExtension(extension_id());
- for (linked_ptr<api::networking_config::NetworkInfo>& ni :
- parameters_->networks) {
+ for (const api::networking_config::NetworkInfo& ni : parameters_->networks) {
// |Type| field must be set to |WiFi|
- if (ni->type != api::networking_config::NETWORK_TYPE_WIFI)
+ if (ni.type != api::networking_config::NETWORK_TYPE_WIFI)
return RespondNow(Error(kUnsupportedNetworkType));
// Either |ssid| or |hex_ssid| must be set.
- if (!ni->ssid.get() && !ni->hex_ssid.get())
+ if (!ni.ssid.get() && !ni.hex_ssid.get())
return RespondNow(Error(kMalformedFilterDescription));
std::string hex_ssid;
- if (ni->ssid.get()) {
- auto ssid_field = ni->ssid.get();
+ if (ni.ssid.get()) {
+ auto ssid_field = ni.ssid.get();
hex_ssid = base::HexEncode(ssid_field->c_str(), ssid_field->size());
}
- if (ni->hex_ssid.get())
- hex_ssid = *ni->hex_ssid.get();
+ if (ni.hex_ssid.get())
+ hex_ssid = *ni.hex_ssid.get();
if (!service->RegisterHexSsid(hex_ssid, extension_id()))
return RespondNow(Error(kMalformedFilterDescriptionWithSSID, hex_ssid));
« no previous file with comments | « extensions/browser/api/management/management_api.cc ('k') | extensions/browser/api/printer_provider/printer_provider_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698