Hide ChromeVox Panel in full-screen mode.

Hide ChromeVox Panel in full-screen mode.

Makes the ChromeVox Panel track when entering and leaving full-screen mode
and hides the panel when in full-screen mode, unless the panel is active.

To activate the ChromeVox Panel using the keyboard:
1. Enable spoken feedback with Ctrl+Alt+Z
2. Place focus inside a webpage
3. Press Search+Shift+Q+Q (press Q twice while holding down those keys)
   to enable the ChromeVox Next beta
4. Now pressing Search+Period will open the ChromeVox menus and Esc will
   close them. Those still function when in full-screen mode.

BUG=587033
Committed: https://crrev.com/d47388ddcf745fe2a4389dbacdcf51f6fecb4e6d
Cr-Commit-Position: refs/heads/master@{#384295}

[dmazzoni, 2016-03-30 08:41:08]

dmazzoni@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2016-03-30 16:08:02]

lgtm

https://codereview.chromium.org/1841393002/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/chromevox_panel.cc (right):

https://codereview.chromium.org/1841393002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/chromevox_panel.cc:183:
ash::wm::GetWindowState(fullscreen_window)->IsFullscreen() &&
nit: Is checking IsFullscreen() necessary? |fullscreen_window| is returned from
GetWindowForFullscreenMode(). It must be in full screen state if it is not null.

[dmazzoni, 2016-03-31 15:25:56]

https://codereview.chromium.org/1841393002/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/chromevox_panel.cc (right):

https://codereview.chromium.org/1841393002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/chromevox_panel.cc:183:
ash::wm::GetWindowState(fullscreen_window)->IsFullscreen() &&
On 2016/03/30 16:08:02, xiyuan wrote:
> nit: Is checking IsFullscreen() necessary? |fullscreen_window| is returned
from
> GetWindowForFullscreenMode(). It must be in full screen state if it is not
null.

Ah, thanks. I misinterpreted and thought it returned the window that should
become full screen too.

[dmazzoni, 2016-03-31 15:29:25]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-03-31 15:29:26]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1841393002/#ps20001
(title: "No need to check window state")

[commit-bot: I haz the power, 2016-03-31 15:29:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841393002/20001

[commit-bot: I haz the power, 2016-03-31 16:04:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 16:06:28]

Description was changed from

==========
Hide ChromeVox Panel in full-screen mode.

Makes the ChromeVox Panel track when entering and leaving full-screen mode
and hides the panel when in full-screen mode, unless the panel is active.

To activate the ChromeVox Panel using the keyboard:
1. Enable spoken feedback with Ctrl+Alt+Z
2. Place focus inside a webpage
3. Press Search+Shift+Q+Q (press Q twice while holding down those keys)
   to enable the ChromeVox Next beta
4. Now pressing Search+Period will open the ChromeVox menus and Esc will
   close them. Those still function when in full-screen mode.

BUG=587033
==========

to

==========
Hide ChromeVox Panel in full-screen mode.

Makes the ChromeVox Panel track when entering and leaving full-screen mode
and hides the panel when in full-screen mode, unless the panel is active.

To activate the ChromeVox Panel using the keyboard:
1. Enable spoken feedback with Ctrl+Alt+Z
2. Place focus inside a webpage
3. Press Search+Shift+Q+Q (press Q twice while holding down those keys)
   to enable the ChromeVox Next beta
4. Now pressing Search+Period will open the ChromeVox menus and Esc will
   close them. Those still function when in full-screen mode.

BUG=587033

Committed: https://crrev.com/d47388ddcf745fe2a4389dbacdcf51f6fecb4e6d
Cr-Commit-Position: refs/heads/master@{#384295}
==========

[commit-bot: I haz the power, 2016-03-31 16:06:29]

Patchset 2 (id:??) landed as
https://crrev.com/d47388ddcf745fe2a4389dbacdcf51f6fecb4e6d
Cr-Commit-Position: refs/heads/master@{#384295}