Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1837053003: Accessibility manager shouldn't try to access ash Shelf from login screen. (Closed)

Created:
4 years, 8 months ago by dmazzoni
Modified:
4 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Accessibility manager shouldn't try to access ash Shelf from login screen. BUG=597000 Committed: https://crrev.com/39d6d4bd6312b9f7379df930f4fde795d04687f0 Cr-Commit-Position: refs/heads/master@{#383847}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update height when profile changes #

Total comments: 2

Patch Set 3 : Update panel height in SetProfile instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 1 chunk +11 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Dependent Patchsets:

Issue 1841393002 Patch 1
Issue 1841393002 Patch 20001

Messages

Total messages: 12 (3 generated)
dmazzoni
4 years, 8 months ago (2016-03-28 21:45:48 UTC) #2
xiyuan
https://codereview.chromium.org/1837053003/diff/1/chrome/browser/chromeos/accessibility/chromevox_panel.cc File chrome/browser/chromeos/accessibility/chromevox_panel.cc (right): https://codereview.chromium.org/1837053003/diff/1/chrome/browser/chromeos/accessibility/chromevox_panel.cc#newcode119 chrome/browser/chromeos/accessibility/chromevox_panel.cc:119: shelf_layout_manager->SetChromeVoxPanelHeight(kPanelHeight); Do we need to worry about shelf not ...
4 years, 8 months ago (2016-03-28 21:48:06 UTC) #3
dmazzoni
https://codereview.chromium.org/1837053003/diff/1/chrome/browser/chromeos/accessibility/chromevox_panel.cc File chrome/browser/chromeos/accessibility/chromevox_panel.cc (right): https://codereview.chromium.org/1837053003/diff/1/chrome/browser/chromeos/accessibility/chromevox_panel.cc#newcode119 chrome/browser/chromeos/accessibility/chromevox_panel.cc:119: shelf_layout_manager->SetChromeVoxPanelHeight(kPanelHeight); On 2016/03/28 21:48:05, xiyuan wrote: > Do we ...
4 years, 8 months ago (2016-03-28 22:29:11 UTC) #4
xiyuan
https://codereview.chromium.org/1837053003/diff/20001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/1837053003/diff/20001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode372 chrome/browser/chromeos/accessibility/accessibility_manager.cc:372: g_accessibility_manager->UpdateChromeVoxPanelHeight(); Do this in AccessibilityManager::SetProfile so that we only ...
4 years, 8 months ago (2016-03-28 22:35:57 UTC) #5
dmazzoni
https://codereview.chromium.org/1837053003/diff/20001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/1837053003/diff/20001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode372 chrome/browser/chromeos/accessibility/accessibility_manager.cc:372: g_accessibility_manager->UpdateChromeVoxPanelHeight(); On 2016/03/28 22:35:56, xiyuan wrote: > Do this ...
4 years, 8 months ago (2016-03-29 20:43:22 UTC) #6
xiyuan
lgtm
4 years, 8 months ago (2016-03-29 20:51:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837053003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837053003/40001
4 years, 8 months ago (2016-03-29 21:03:53 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 22:18:12 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 22:19:02 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/39d6d4bd6312b9f7379df930f4fde795d04687f0
Cr-Commit-Position: refs/heads/master@{#383847}

Powered by Google App Engine
This is Rietveld 408576698