third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h - Issue 1841363003: Replace RELEASE_ASSERT_WITH_SECURITY_IMPLICATION with SECURITY_CHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

Issue 1841363003: Replace RELEASE_ASSERT_WITH_SECURITY_IMPLICATION with SECURITY_CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h ('k') | third_party/WebKit/Source/core/dom/NodeRareData.cpp » ('j') | third_party/WebKit/Source/wtf/Assertions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

index 493352d7b64ef233b812bbb67f375a23c4546c24..7f2fdd8d6e867479d114633a38bbf5204c2c9312 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

@@ -93,7 +93,7 @@ inline v8::Local<v8::Object> V8DOMWrapper::associateObjectWithWrapper(v8::Isolat

setNativeInfo(wrapper, wrapperTypeInfo, impl);

ASSERT(hasInternalFieldsSet(wrapper));

}

- RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(toScriptWrappable(wrapper) == impl);

+ SECURITY_CHECK(toScriptWrappable(wrapper) == impl);

return wrapper;

}

@@ -104,7 +104,7 @@ inline v8::Local<v8::Object> V8DOMWrapper::associateObjectWithWrapper(v8::Isolat

setNativeInfo(wrapper, wrapperTypeInfo, ScriptWrappable::fromNode(node));

ASSERT(hasInternalFieldsSet(wrapper));

}

- RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(toScriptWrappable(wrapper) == ScriptWrappable::fromNode(node));

+ SECURITY_CHECK(toScriptWrappable(wrapper) == ScriptWrappable::fromNode(node));

return wrapper;

}