Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 1841363003: Replace RELEASE_ASSERT_WITH_SECURITY_IMPLICATION with SECURITY_CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
index d47185a86a87790091895cf8ffd499565e25ab21..d827ededa6b8d2a60bf153d2cdc2f4d6e01998b2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
@@ -157,7 +157,7 @@ protected:
{
// We must not get deleted as long as we contain a wrapper. If this happens, we screwed up ref
// counting somewhere. Crash here instead of crashing during a later gc cycle.
- RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(!containsWrapper());
+ SECURITY_CHECK(!containsWrapper());
}
#endif
// With Oilpan we don't need a ScriptWrappable destructor.
@@ -173,7 +173,7 @@ private:
void disposeWrapper(const v8::WeakCallbackInfo<ScriptWrappable>& data)
{
auto scriptWrappable = reinterpret_cast<ScriptWrappable*>(data.GetInternalField(v8DOMWrapperObjectIndex));
- RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(scriptWrappable == this);
+ SECURITY_CHECK(scriptWrappable == this);
RELEASE_ASSERT(containsWrapper());
m_wrapper.Reset();
}

Powered by Google App Engine
This is Rietveld 408576698