Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1841343002: Deinline body of ImageSkiaStorage. (Closed)

Created:
4 years, 8 months ago by Peter Kasting
Modified:
4 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, rsesek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deinline body of ImageSkiaStorage. I'm going to be adding another function to this class, and it's a bit hard to read since the class is rather long. This also does some minor comment fixups and switches from the Matcher functor to a lambda. Should be no functional change. BUG=none TEST=none Committed: https://crrev.com/2bd8b487468f1a1f5dd93a7c08470715320342ec Cr-Commit-Position: refs/heads/master@{#384057}

Patch Set 1 #

Patch Set 2 : Remove added bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -148 lines) Patch
M ui/gfx/image/image_skia.cc View 1 4 chunks +149 lines, -148 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Peter Kasting
4 years, 8 months ago (2016-03-30 03:12:33 UTC) #2
oshima
lgtm
4 years, 8 months ago (2016-03-30 14:22:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841343002/20001
4 years, 8 months ago (2016-03-30 18:13:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 19:37:06 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:05:30 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bd8b487468f1a1f5dd93a7c08470715320342ec
Cr-Commit-Position: refs/heads/master@{#384057}

Powered by Google App Engine
This is Rietveld 408576698