Make HasRepresentation() work better for vector images.

Make HasRepresentation() work better for vector images.

Since vector images do not have an initial, preset group of representations
loaded, if GetRepresentation() has not yet been called for a particular scale
factor, HasRepresentation() will return false, even though a call to
GetRepresentation() would succeed.  This plumbs a new function that allow vector
images to say that they can provide a representation at any scale factor, and
thus HasRepresentation() can succeed as long as the image is not
VECTOR_ICON_NONE.

For the rationale that led to this, see the CL comments on
https://codereview.chromium.org/1829353002/ .

BUG=none
TEST=none

Committed: https://crrev.com/0c287a38f4d35d9e01cee7691a37b1ea0e85263a
Cr-Commit-Position: refs/heads/master@{#384132}

[Peter Kasting, 2016-03-30 03:29:49]

pkasting@chromium.org changed reviewers:
+ estade@chromium.org, oshima@chromium.org

[Peter Kasting, 2016-03-30 03:29:49]

estade: OWNERS for paint_vector_icon.cc
oshima: Review.  Please verify that my understanding of how HasRepresentation()
ought to work -- namely, that for a vector icon, it ought to return true for any
scale factor even when we have not yet stored a representation for that scale
factor, since GetRepresentation() will be able to succeed -- is correct.

[oshima, 2016-03-30 19:34:34]

On 2016/03/30 03:29:49, Peter Kasting wrote:
> estade: OWNERS for paint_vector_icon.cc
> oshima: Review.  Please verify that my understanding of how
HasRepresentation()
> ought to work -- namely, that for a vector icon, it ought to return true for
any
> scale factor even when we have not yet stored a representation for that scale
> factor, since GetRepresentation() will be able to succeed -- is correct.

IIRC, this is for the case when you want to provide your own image for given
scale using AddRepresentation, rather than auto scaling or relying on the
source.

This looks fine for vector icon. You may want to add
DCHECK(!HasRepresentationAtAllScales()) in AddRepresetntation to prevent adding
image to vector icon by accident.

lgtm

[Evan Stade, 2016-03-30 21:31:51]

vector file lgtm

[Peter Kasting, 2016-03-30 21:39:09]

On 2016/03/30 19:34:34, oshima wrote:
> On 2016/03/30 03:29:49, Peter Kasting wrote:
> > estade: OWNERS for paint_vector_icon.cc
> > oshima: Review.  Please verify that my understanding of how
> HasRepresentation()
> > ought to work -- namely, that for a vector icon, it ought to return true for
> any
> > scale factor even when we have not yet stored a representation for that
scale
> > factor, since GetRepresentation() will be able to succeed -- is correct.
> 
> IIRC, this is for the case when you want to provide your own image for given
> scale using AddRepresentation, rather than auto scaling or relying on the
> source.
> 
> This looks fine for vector icon. You may want to add
> DCHECK(!HasRepresentationAtAllScales()) in AddRepresetntation to prevent
adding
> image to vector icon by accident.

Sure, that makes sense.  Done.

[Peter Kasting, 2016-03-30 21:39:20]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-03-30 21:39:20]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1846513002/#ps60001
(title: "Add DCHECK")

[commit-bot: I haz the power, 2016-03-30 21:39:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846513002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846513002/60001

[commit-bot: I haz the power, 2016-03-30 23:04:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-30 23:05:53]

Description was changed from

==========
Make HasRepresentation() work better for vector images.

Since vector images do not have an initial, preset group of representations
loaded, if GetRepresentation() has not yet been called for a particular scale
factor, HasRepresentation() will return false, even though a call to
GetRepresentation() would succeed.  This plumbs a new function that allow vector
images to say that they can provide a representation at any scale factor, and
thus HasRepresentation() can succeed as long as the image is not
VECTOR_ICON_NONE.

For the rationale that led to this, see the CL comments on
https://codereview.chromium.org/1829353002/ .

BUG=none
TEST=none
==========

to

==========
Make HasRepresentation() work better for vector images.

Since vector images do not have an initial, preset group of representations
loaded, if GetRepresentation() has not yet been called for a particular scale
factor, HasRepresentation() will return false, even though a call to
GetRepresentation() would succeed.  This plumbs a new function that allow vector
images to say that they can provide a representation at any scale factor, and
thus HasRepresentation() can succeed as long as the image is not
VECTOR_ICON_NONE.

For the rationale that led to this, see the CL comments on
https://codereview.chromium.org/1829353002/ .

BUG=none
TEST=none

Committed: https://crrev.com/0c287a38f4d35d9e01cee7691a37b1ea0e85263a
Cr-Commit-Position: refs/heads/master@{#384132}
==========

[commit-bot: I haz the power, 2016-03-30 23:05:55]

Patchset 4 (id:??) landed as
https://crrev.com/0c287a38f4d35d9e01cee7691a37b1ea0e85263a
Cr-Commit-Position: refs/heads/master@{#384132}