Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1841323003: [css-grid] Fix positioned items with grid gaps (Closed)

Created:
4 years, 8 months ago by Manuel Rego
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-positioned-rtl-after-refactoring
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix positioned items with grid gaps When we place a positioned items between in a grid with gaps, we were not taking into accounts the gutter size. We've to use that size to properly place and size the item. Added new test checking the right behavior. BUG=566265 TEST=fast/css-grid-layout/grid-positioned-items-gaps.html TEST=fast/css-grid-layout/grid-positioned-items-gaps-rtl.html Committed: https://crrev.com/a4144158053ed7c97a04e5a21f491548e06f6d7d Cr-Commit-Position: refs/heads/master@{#384588}

Patch Set 1 #

Patch Set 2 : Minor fix #

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+617 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-items-gaps.html View 1 chunk +305 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-items-gaps-rtl.html View 1 chunk +305 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Manuel Rego
This patch has been developed on top of: http://crrev.com/1841073002/ So, please review the other one ...
4 years, 8 months ago (2016-03-30 12:52:28 UTC) #2
svillar
Looks good. lgtm Perhaps it'd be good to add a comment mentioning that vectors store ...
4 years, 8 months ago (2016-04-01 09:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841323003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841323003/40001
4 years, 8 months ago (2016-04-01 10:44:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203887)
4 years, 8 months ago (2016-04-01 12:11:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841323003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841323003/40001
4 years, 8 months ago (2016-04-01 14:22:56 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 15:16:50 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 15:18:20 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a4144158053ed7c97a04e5a21f491548e06f6d7d
Cr-Commit-Position: refs/heads/master@{#384588}

Powered by Google App Engine
This is Rietveld 408576698