Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1841233002: Update SkComposeImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More cleanup #

Patch Set 3 : more cleanup #

Patch Set 4 : ?? #

Total comments: 2

Patch Set 5 : Address code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -66 lines) Patch
M gm/testimagefilters.cpp View 1 2 1 chunk +33 lines, -37 lines 0 comments Download
M include/effects/SkComposeImageFilter.h View 1 2 3 4 1 chunk +15 lines, -8 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
robertphillips
4 years, 8 months ago (2016-03-29 21:21:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841233002/40001
4 years, 8 months ago (2016-03-29 21:54:29 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1567)
4 years, 8 months ago (2016-03-29 21:57:00 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841233002/60001
4 years, 8 months ago (2016-03-30 14:44:43 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 15:02:20 UTC) #12
f(malita)
lgtm https://codereview.chromium.org/1841233002/diff/60001/include/effects/SkComposeImageFilter.h File include/effects/SkComposeImageFilter.h (right): https://codereview.chromium.org/1841233002/diff/60001/include/effects/SkComposeImageFilter.h#newcode22 include/effects/SkComposeImageFilter.h:22: sk_sp<SkImageFilter> inputs[2] = { outer, inner }; nit: ...
4 years, 8 months ago (2016-03-30 18:04:38 UTC) #13
robertphillips
https://codereview.chromium.org/1841233002/diff/60001/include/effects/SkComposeImageFilter.h File include/effects/SkComposeImageFilter.h (right): https://codereview.chromium.org/1841233002/diff/60001/include/effects/SkComposeImageFilter.h#newcode22 include/effects/SkComposeImageFilter.h:22: sk_sp<SkImageFilter> inputs[2] = { outer, inner }; On 2016/03/30 ...
4 years, 8 months ago (2016-03-30 18:23:27 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841233002/80001
4 years, 8 months ago (2016-03-30 18:23:49 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 18:39:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841233002/80001
4 years, 8 months ago (2016-03-30 19:32:01 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 19:33:01 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/491fb17cab07574a9d5656c1c97ad0acc3af5c70

Powered by Google App Engine
This is Rietveld 408576698