Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: gm/testimagefilters.cpp

Issue 1841233002: Update SkComposeImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address code review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/effects/SkComposeImageFilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "gm.h" 8 #include "gm.h"
9 #include "SkCanvas.h" 9 #include "SkCanvas.h"
10 #include "SkColorFilter.h" 10 #include "SkColorFilter.h"
11 #include "SkColorPriv.h" 11 #include "SkColorPriv.h"
12 #include "SkShader.h" 12 #include "SkShader.h"
13 13
14 #include "SkBlurImageFilter.h" 14 #include "SkBlurImageFilter.h"
15 #include "SkColorFilterImageFilter.h" 15 #include "SkColorFilterImageFilter.h"
16 #include "SkComposeImageFilter.h" 16 #include "SkComposeImageFilter.h"
17 #include "SkMergeImageFilter.h" 17 #include "SkMergeImageFilter.h"
18 #include "SkOffsetImageFilter.h" 18 #include "SkOffsetImageFilter.h"
19 #include "SkTestImageFilters.h" 19 #include "SkTestImageFilters.h"
20 20
21 #define FILTER_WIDTH SkIntToScalar(150) 21 #define FILTER_WIDTH SkIntToScalar(150)
22 #define FILTER_HEIGHT SkIntToScalar(200) 22 #define FILTER_HEIGHT SkIntToScalar(200)
23 23
24 static SkImageFilter* make0() { return SkDownSampleImageFilter::Create(SK_Scalar 1 / 5); } 24 static SkImageFilter* make0() {
25 static SkImageFilter* make1() { return SkOffsetImageFilter::Create(SkIntToScalar (16), SkIntToScalar(16)); } 25 return SkDownSampleImageFilter::Create(SK_Scalar1 / 5);
26 }
27
28 static SkImageFilter* make1() {
29 return SkOffsetImageFilter::Create(SkIntToScalar(16), SkIntToScalar(16));
30 }
31
26 static SkImageFilter* make2() { 32 static SkImageFilter* make2() {
27 auto cf = SkColorFilter::MakeModeFilter(SK_ColorBLUE, SkXfermode::kSrcIn_Mod e); 33 sk_sp<SkColorFilter> cf(SkColorFilter::MakeModeFilter(SK_ColorBLUE, SkXfermo de::kSrcIn_Mode));
28 return SkColorFilterImageFilter::Create(cf.get()); 34 return SkColorFilterImageFilter::Create(cf.get());
29 } 35 }
36
30 static SkImageFilter* make3() { 37 static SkImageFilter* make3() {
31 return SkBlurImageFilter::Create(8, 0); 38 return SkBlurImageFilter::Create(8, 0);
32 } 39 }
33 40
34 static SkImageFilter* make4() { 41 static SkImageFilter* make4() {
35 SkImageFilter* outer = SkOffsetImageFilter::Create(SkIntToScalar(16), SkIntT oScalar(16)); 42 sk_sp<SkImageFilter> outer(SkOffsetImageFilter::Create(SkIntToScalar(16), Sk IntToScalar(16)));
36 SkImageFilter* inner = SkDownSampleImageFilter::Create(SK_Scalar1 / 5); 43 sk_sp<SkImageFilter> inner(SkDownSampleImageFilter::Create(SK_Scalar1 / 5));
37 SkAutoUnref aur0(outer); 44 return SkComposeImageFilter::Make(std::move(outer), std::move(inner)).releas e();
38 SkAutoUnref aur1(inner);
39 return SkComposeImageFilter::Create(outer, inner);
40 } 45 }
46
41 static SkImageFilter* make5() { 47 static SkImageFilter* make5() {
42 SkImageFilter* first = SkOffsetImageFilter::Create(SkIntToScalar(16), SkIntT oScalar(16)); 48 sk_sp<SkImageFilter> first(SkOffsetImageFilter::Create(SkIntToScalar(16), Sk IntToScalar(16)));
43 SkImageFilter* second = SkDownSampleImageFilter::Create(SK_Scalar1 / 5); 49 sk_sp<SkImageFilter> second(SkDownSampleImageFilter::Create(SK_Scalar1 / 5)) ;
44 SkAutoUnref aur0(first); 50 return SkMergeImageFilter::Create(first.get(), second.get());
45 SkAutoUnref aur1(second);
46 return SkMergeImageFilter::Create(first, second);
47 } 51 }
48 52
49 static SkImageFilter* make6() { 53 static SkImageFilter* make6() {
50 SkImageFilter* outer = SkOffsetImageFilter::Create(SkIntToScalar(16), SkIntT oScalar(16)); 54 sk_sp<SkImageFilter> outer(SkOffsetImageFilter::Create(SkIntToScalar(16), Sk IntToScalar(16)));
51 SkImageFilter* inner = SkDownSampleImageFilter::Create(SK_Scalar1 / 5); 55 sk_sp<SkImageFilter> inner(SkDownSampleImageFilter::Create(SK_Scalar1 / 5));
52 SkAutoUnref aur0(outer); 56 sk_sp<SkImageFilter> compose(SkComposeImageFilter::Make(std::move(outer), st d::move(inner)));
53 SkAutoUnref aur1(inner);
54 SkImageFilter* compose = SkComposeImageFilter::Create(outer, inner);
55 SkAutoUnref aur2(compose);
56 57
57 auto cf = SkColorFilter::MakeModeFilter(0x880000FF, SkXfermode::kSrcIn_Mode) ; 58 sk_sp<SkColorFilter> cf(SkColorFilter::MakeModeFilter(0x880000FF, SkXfermode ::kSrcIn_Mode));
58 SkImageFilter* blue = SkColorFilterImageFilter::Create(cf.get()); 59 sk_sp<SkImageFilter> blue(SkColorFilterImageFilter::Create(cf.get()));
59 SkAutoUnref aur4(blue);
60 60
61 return SkMergeImageFilter::Create(compose, blue); 61 return SkMergeImageFilter::Create(compose.get(), blue.get());
62 } 62 }
63 63
64 static SkImageFilter* make7() { 64 static SkImageFilter* make7() {
65 SkImageFilter* outer = SkOffsetImageFilter::Create(SkIntToScalar(16), SkIntT oScalar(16)); 65 sk_sp<SkImageFilter> outer(SkOffsetImageFilter::Create(SkIntToScalar(16), Sk IntToScalar(16)));
66 SkImageFilter* inner = make3(); 66 sk_sp<SkImageFilter> inner(make3());
67 SkAutoUnref aur0(outer); 67 sk_sp<SkImageFilter> compose(SkComposeImageFilter::Make(std::move(outer), st d::move(inner)));
68 SkAutoUnref aur1(inner);
69 SkImageFilter* compose = SkComposeImageFilter::Create(outer, inner);
70 SkAutoUnref aur2(compose);
71 68
72 auto cf = SkColorFilter::MakeModeFilter(0x880000FF, SkXfermode::kSrcIn_Mode) ; 69 sk_sp<SkColorFilter> cf(SkColorFilter::MakeModeFilter(0x880000FF, SkXfermode ::kSrcIn_Mode));
73 SkImageFilter* blue = SkColorFilterImageFilter::Create(cf.get()); 70 sk_sp<SkImageFilter> blue(SkColorFilterImageFilter::Create(cf.get()));
74 SkAutoUnref aur4(blue);
75 71
76 return SkMergeImageFilter::Create(compose, blue); 72 return SkMergeImageFilter::Create(compose.get(), blue.get());
77 } 73 }
78 74
79 static void draw0(SkCanvas* canvas) { 75 static void draw0(SkCanvas* canvas) {
80 SkPaint p; 76 SkPaint p;
81 p.setAntiAlias(true); 77 p.setAntiAlias(true);
82 SkRect r = SkRect::MakeWH(FILTER_WIDTH, FILTER_HEIGHT); 78 SkRect r = SkRect::MakeWH(FILTER_WIDTH, FILTER_HEIGHT);
83 r.inset(SK_Scalar1 * 12, SK_Scalar1 * 12); 79 r.inset(SK_Scalar1 * 12, SK_Scalar1 * 12);
84 p.setColor(SK_ColorRED); 80 p.setColor(SK_ColorRED);
85 canvas->drawOval(r, p); 81 canvas->drawOval(r, p);
86 } 82 }
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 } 125 }
130 } 126 }
131 127
132 private: 128 private:
133 typedef GM INHERITED; 129 typedef GM INHERITED;
134 }; 130 };
135 131
136 ////////////////////////////////////////////////////////////////////////////// 132 //////////////////////////////////////////////////////////////////////////////
137 133
138 DEF_GM( return new TestImageFiltersGM; ) 134 DEF_GM( return new TestImageFiltersGM; )
OLDNEW
« no previous file with comments | « no previous file | include/effects/SkComposeImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698