fpdfsdk/javascript/JS_Value.h - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Value.h

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Revert XFA botch. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/JS_Value.h

diff --git a/fpdfsdk/javascript/JS_Value.h b/fpdfsdk/javascript/JS_Value.h

index 69656ea18c35b7025b6639f8b1596eb77c46720f..202e250aae92045e9a6689d395c1bb6020ab097f 100644

--- a/fpdfsdk/javascript/JS_Value.h

+++ b/fpdfsdk/javascript/JS_Value.h

@@ -139,7 +139,7 @@ class CJS_Array {

virtual ~CJS_Array();

void Attach(v8::Local<v8::Array> pArray);

- void GetElement(unsigned index, CJS_Value& value);

+ void GetObjectBy(unsigned index, CJS_Value& value);

Tom Sepez 2016/03/29 21:01:43 .... and this is still hosed.

void SetElement(unsigned index, CJS_Value value);

int GetLength();

FX_BOOL IsAttached();

« no previous file with comments | « fpdfsdk/javascript/Field.cpp ('k') | fpdfsdk/javascript/JS_Value.cpp » ('j') | no next file with comments »