fpdfsdk/javascript/PublicMethods.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/PublicMethods.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/PublicMethods.cpp

diff --git a/fpdfsdk/javascript/PublicMethods.cpp b/fpdfsdk/javascript/PublicMethods.cpp

index a4c13564c813d74348f6bbdadb6372589d705943..288c6771d8556b2549cf2200aa2e705c74605a11 100644

--- a/fpdfsdk/javascript/PublicMethods.cpp

+++ b/fpdfsdk/javascript/PublicMethods.cpp

@@ -1722,7 +1722,7 @@ FX_BOOL CJS_PublicMethods::AFSimple_Calculate(

for (int i = 0, isz = FieldNameArray.GetLength(); i < isz; i++) {

CJS_Value jsValue(pRuntime);

- FieldNameArray.GetElement(i, jsValue);

+ FieldNameArray.GetObjectBy(i, jsValue);

CFX_WideString wsFieldName = jsValue.ToCFXWideString();

for (int j = 0, jsz = pInterForm->CountFields(wsFieldName); j < jsz; j++) {