Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/javascript/JS_Value.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Use "At" for arrays. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/javascript/JS_Value.h ('k') | fpdfsdk/javascript/PublicMethods.cpp » ('j') | xfa/fxfa/parser/xfa_basic_imp.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/JS_Value.cpp
diff --git a/fpdfsdk/javascript/JS_Value.cpp b/fpdfsdk/javascript/JS_Value.cpp
index 4d2a1d44a8e61cc961678bd2931ca3d9c694f78d..37035a6eb19efede663ec7905bdcd98bb6542cf9 100644
--- a/fpdfsdk/javascript/JS_Value.cpp
+++ b/fpdfsdk/javascript/JS_Value.cpp
@@ -420,7 +420,7 @@ FX_BOOL CJS_Array::IsAttached() {
return FALSE;
}
-void CJS_Array::GetElement(unsigned index, CJS_Value& value) {
+void CJS_Array::GetObjectBy(unsigned index, CJS_Value& value) {
if (m_pArray.IsEmpty())
return;
v8::Local<v8::Value> p =
« no previous file with comments | « fpdfsdk/javascript/JS_Value.h ('k') | fpdfsdk/javascript/PublicMethods.cpp » ('j') | xfa/fxfa/parser/xfa_basic_imp.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698