Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: core/fxcrt/fx_xml_parser.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Use "At" for arrays. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fxcrt/fx_xml_parser.cpp
diff --git a/core/fxcrt/fx_xml_parser.cpp b/core/fxcrt/fx_xml_parser.cpp
index 9cdf73ca90dc9f0c2238ce7613ff6570f60ba91e..302a55531f7d7fb4b6ad5283a7aaf92fb2d10cbe 100644
--- a/core/fxcrt/fx_xml_parser.cpp
+++ b/core/fxcrt/fx_xml_parser.cpp
@@ -701,7 +701,7 @@ CFX_WideString CXML_Element::GetContent(uint32_t index) const {
}
return CFX_WideString();
}
-CXML_Element* CXML_Element::GetElement(uint32_t index) const {
+CXML_Element* CXML_Element::GetObjectBy(uint32_t index) const {
if (index < m_Children.size() && m_Children[index].type == Element) {
return static_cast<CXML_Element*>(m_Children[index].child);
}
@@ -722,9 +722,9 @@ uint32_t CXML_Element::CountElements(const CFX_ByteStringC& space,
}
return count;
}
-CXML_Element* CXML_Element::GetElement(const CFX_ByteStringC& space,
- const CFX_ByteStringC& tag,
- int index) const {
+CXML_Element* CXML_Element::GetObjectBy(const CFX_ByteStringC& space,
+ const CFX_ByteStringC& tag,
+ int index) const {
if (index < 0)
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698