core/fpdftext/fpdf_text_int.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdftext/fpdf_text_int.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdftext/fpdf_text_int.cpp

diff --git a/core/fpdftext/fpdf_text_int.cpp b/core/fpdftext/fpdf_text_int.cpp

index f8f201b547cb04a59db18788b7e22dfeaf35326c..8d8fa4e9ed87eb321b2042a88c853e1376f863e9 100644

--- a/core/fpdftext/fpdf_text_int.cpp

+++ b/core/fpdftext/fpdf_text_int.cpp

@@ -1125,7 +1125,7 @@ int32_t CPDF_TextPage::PreMarkedContent(PDFTEXT_Obj Obj) {

continue;

pDict = item.GetParam();

CPDF_String* temp =

- ToString(pDict ? pDict->GetElement("ActualText") : nullptr);

+ ToString(pDict ? pDict->GetObjectBy("ActualText") : nullptr);

if (temp) {

bExist = TRUE;

actText = temp->GetUnicodeText();