PNaCl Dynamic Linking: Tests storing dependencies from command line in PLL.

PNaCl Dynamic Linking: Tests storing dependencies from command line in PLL.

Tests https://codereview.chromium.org/1829793002/

TEST=pll_symbols_test
BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/dabc9f016f3cb4cb262f7c9b43c60800906f3432

[Sean Klein, 2016-03-29 17:58:56]

smklein@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Mark Seaborn, 2016-03-29 19:01:11]

LGTM, thanks

https://codereview.chromium.org/1841113002/diff/1/src/untrusted/pll_loader/pl...
File src/untrusted/pll_loader/pll_root.h (right):

https://codereview.chromium.org/1841113002/diff/1/src/untrusted/pll_loader/pl...
src/untrusted/pll_loader/pll_root.h:53: const char *dependencies_list;
How about a comment:

Null-separated list of library sonames.  For example, "libfoo.so\0libbar.so"
(including a trailing null terminator), which would have dependencies_count = 2.

https://codereview.chromium.org/1841113002/diff/1/tests/pnacl_dynamic_loading...
File tests/pnacl_dynamic_loading/nacl.scons (right):

https://codereview.chromium.org/1841113002/diff/1/tests/pnacl_dynamic_loading...
tests/pnacl_dynamic_loading/nacl.scons:94: llvm_passes='-nacl-global-cleanup
-expand-varargs '
Nit: It's better for arguments to line up:

// good (aligned with "(")
SomeFunc(arg1, arg2,
         arg3,
         arg4, ...);

// good (4-space indent)
SomeFunc(
    arg1, arg2,
    arg3,
    arg4, ...);

// less good
SomeFunc(arg1, arg2,
    arg3,
    arg4, ...);

See
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Calls

[Sean Klein, 2016-03-29 19:43:56]

https://codereview.chromium.org/1841113002/diff/1/src/untrusted/pll_loader/pl...
File src/untrusted/pll_loader/pll_root.h (right):

https://codereview.chromium.org/1841113002/diff/1/src/untrusted/pll_loader/pl...
src/untrusted/pll_loader/pll_root.h:53: const char *dependencies_list;
On 2016/03/29 19:01:11, Mark Seaborn wrote:
> How about a comment:
> 
> Null-separated list of library sonames.  For example, "libfoo.so\0libbar.so"
> (including a trailing null terminator), which would have dependencies_count =
2.

Done.

https://codereview.chromium.org/1841113002/diff/1/tests/pnacl_dynamic_loading...
File tests/pnacl_dynamic_loading/nacl.scons (right):

https://codereview.chromium.org/1841113002/diff/1/tests/pnacl_dynamic_loading...
tests/pnacl_dynamic_loading/nacl.scons:94: llvm_passes='-nacl-global-cleanup
-expand-varargs '
On 2016/03/29 19:01:11, Mark Seaborn wrote:
> Nit: It's better for arguments to line up:
> 
> // good (aligned with "(")
> SomeFunc(arg1, arg2,
>          arg3,
>          arg4, ...);
> 
> // good (4-space indent)
> SomeFunc(
>     arg1, arg2,
>     arg3,
>     arg4, ...);
> 
> // less good
> SomeFunc(arg1, arg2,
>     arg3,
>     arg4, ...);
> 
> See
>
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Calls

Oops. Sorry, I know I've made this mistake before. Fixed.

[Sean Klein, 2016-03-29 20:41:59]

The CQ bit was checked by smklein@chromium.org

[Sean Klein, 2016-03-29 20:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org
Link to the patchset: https://codereview.chromium.org/1841113002/#ps20001
(title: "Code Review")

[commit-bot: I haz the power, 2016-03-29 20:42:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841113002/20001

[commit-bot: I haz the power, 2016-03-29 21:43:24]

Description was changed from

==========
PNaCl Dynamic Linking: Tests storing dependencies from command line in PLL.

Tests https://codereview.chromium.org/1829793002/

TEST=pll_symbols_test
BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
==========

to

==========
PNaCl Dynamic Linking: Tests storing dependencies from command line in PLL.

Tests https://codereview.chromium.org/1829793002/

TEST=pll_symbols_test
BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/dabc9f016...
==========

[commit-bot: I haz the power, 2016-03-29 21:43:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/dabc9f016...