PNaCl Dynamic Linking: Tests storing dependencies from command line in PLL.

tests/pnacl_dynamic_loading/nacl.scons

 # -*- python -*-
 # Copyright (c) 2014 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 Import('env')
 
 if not env.Bit('bitcode'):
   Return()
 # Translating the PSO to an ELF DSO doesn't work on x86-64 yet.  The
@@ skipping 66 matching lines @@
 node = env.CommandSelLdrTestNacl(
     'dynloader_test.out', dynloader_test, [dso1, dso2, dso3],
     # Add '-a' to enable filesystem access for opening DSOs.
     sel_ldr_flags=['-a'])
 env.AddNodeToTestSuite(
     node, ['small_tests', 'toolchain_tests'],
     'run_pnacl_dynamic_loading_test', is_broken=is_broken)
 
 
 # Use of the ConvertToPSO pass requires this toolchain version.
-if env['TOOLCHAIN_FEATURE_VERSION'] < 23:
+if env['TOOLCHAIN_FEATURE_VERSION'] < 24:
   Return()
 
-test_pll = MakeAndTranslatePll('test_pll', 'test_pll.c')
+# TODO(smklein): These LLVM passes should be automatically applied by the
+# drivers. Once support for dependencies has been plumbed through the drivers,
+# use the "-l" linker flags and don't explicitly declare any LLVM passes.
+test_pll = MakeAndTranslatePso('test_pll', [env.ComponentObject('test_pll.c')],
+    llvm_passes='-nacl-global-cleanup -expand-varargs '

[Mark Seaborn, 2016/03/29 19:01:11]

Nit: It's better for arguments to line up:

// good (aligned with "(")
SomeFunc(arg1, arg2,
         arg3,
         arg4, ...);

// good (4-space indent)
SomeFunc(
    arg1, arg2,
    arg3,
    arg4, ...);

// less good
SomeFunc(arg1, arg2,
    arg3,
    arg4, ...);

See
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Calls

[Sean Klein, 2016/03/29 19:43:56]

Oops. Sorry, I know I've made this mistake before. Fixed.

+    '-rewrite-pnacl-library-calls -rewrite-llvm-intrinsic-calls '
+    '-convert-to-pso -convert-to-pso-deps=libfoo.so,libbar.so '
+    '-pnacl-abi-simplify-postopt')
+
 test_pll_tls = MakeAndTranslatePll('test_pll_tls', 'test_pll_tls.c')
 
 pll_symbols_test = env.ComponentProgram(
     'pll_symbols_test', ['pll_symbols_test.cc'],
     EXTRA_LIBS=['${NONIRT_LIBS}', 'pnacl_dynloader', 'pll_loader_lib'])
 
 node = env.CommandSelLdrTestNacl(
     'pll_symbols_test.out', pll_symbols_test, [test_pll, test_pll_tls],
     # Add '-a' to enable filesystem access for opening DSOs.
     sel_ldr_flags=['-a'])
@@ skipping 42 matching lines @@
 
 node = env.CommandSelLdrTestNacl(
     'pll_hello_world_test.out', pll_loader,
     [translated_pll_libc, translated_pll_hello_world],
     # Add '-a' to enable filesystem access for opening DSOs.
     sel_ldr_flags=['-a'],
     stdout_golden=env.File('../hello_world/hello_world.stdout'))
 env.AddNodeToTestSuite(
     node, ['small_tests', 'toolchain_tests'],
     'run_pll_hello_world_test', is_broken=is_broken)