[OfflinePages] Adding tests to OfflinePageBridge#getAllPagesAsync

[OfflinePages] Adding tests to OfflinePageBridge#getAllPagesAsync

Adds a few junit tests for the getAllPagesAsync as a template for other
asynchronous functions on OfflinePageBridge.

BUG=598476, 595252
R=dewittj@chromium.org

Committed: https://crrev.com/2f961ea9dae09bab5060fa8bb80584144f11276b
Cr-Commit-Position: refs/heads/master@{#383844}

[fgorski, 2016-03-29 17:48:57]

PTAL

[dewittj, 2016-03-29 19:44:13]

lgtm

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
(right):

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:227:

There is no check that nothing happens if the model is never loaded, right?

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:272:
private static List<OfflinePageItem> convertToListOfOfflinePages(Object o) {
One possibly better way to do this without warnings (I think) is:

List l = (List)o;
List<OfflinePageItem> result = new ArrayList<>();
for (Object itemAsObject : l) {
  result.add((OfflinePageItem)itemAsObject);
}
return result;

[dewittj, 2016-03-29 19:46:28]

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
(right):

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:233:
});
Do you need
 Robolectric.flushBackgroundThreadScheduler();

[dewittj, 2016-03-29 19:52:14]

On 2016/03/29 19:46:28, dewittj wrote:
>
https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
> File
>
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
> (right):
> 
>
https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
>
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:233:
> });
> Do you need
>  Robolectric.flushBackgroundThreadScheduler();

or Robolectric.runBackgroundTasks()?

[dewittj, 2016-03-29 19:53:59]

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jun...

is an example of an asynchronous test.

[dewittj, 2016-03-29 21:17:04]

lgtm++

https://codereview.chromium.org/1841103002/diff/20001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
(right):

https://codereview.chromium.org/1841103002/diff/20001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:212:
MultipleOfflinePageItemCallback callback = spy(new
MultipleOfflinePageItemCallback() {
may want a static callback to avoid duplication of code?

[fgorski, 2016-03-29 21:42:40]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-03-29 21:42:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/1841103002/#ps40001
(title: "Extracting 2 methods from tests")

[commit-bot: I haz the power, 2016-03-29 21:43:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841103002/40001

[fgorski, 2016-03-29 21:46:47]

All done

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
(right):

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:227:

On 2016/03/29 19:44:13, dewittj wrote:
> There is no check that nothing happens if the model is never loaded, right?

Done.

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:233:
});
On 2016/03/29 19:46:28, dewittj wrote:
> Do you need
>  Robolectric.flushBackgroundThreadScheduler();

Done.

https://codereview.chromium.org/1841103002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:272:
private static List<OfflinePageItem> convertToListOfOfflinePages(Object o) {
On 2016/03/29 19:44:13, dewittj wrote:
> One possibly better way to do this without warnings (I think) is:
> 
> List l = (List)o;
> List<OfflinePageItem> result = new ArrayList<>();
> for (Object itemAsObject : l) {
>   result.add((OfflinePageItem)itemAsObject);
> }
> return result;

Done.

https://codereview.chromium.org/1841103002/diff/20001/chrome/android/junit/sr...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
(right):

https://codereview.chromium.org/1841103002/diff/20001/chrome/android/junit/sr...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:212:
MultipleOfflinePageItemCallback callback = spy(new
MultipleOfflinePageItemCallback() {
On 2016/03/29 21:17:04, dewittj wrote:
> may want a static callback to avoid duplication of code?

Done.

[commit-bot: I haz the power, 2016-03-29 22:09:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-29 22:11:21]

Description was changed from

==========
[OfflinePages] Adding tests to OfflinePageBridge#getAllPagesAsync

Adds a few junit tests for the getAllPagesAsync as a template for other
asynchronous functions on OfflinePageBridge.

BUG=598476,595252
R=dewittj@chromium.org
==========

to

==========
[OfflinePages] Adding tests to OfflinePageBridge#getAllPagesAsync

Adds a few junit tests for the getAllPagesAsync as a template for other
asynchronous functions on OfflinePageBridge.

BUG=598476,595252
R=dewittj@chromium.org

Committed: https://crrev.com/2f961ea9dae09bab5060fa8bb80584144f11276b
Cr-Commit-Position: refs/heads/master@{#383844}
==========

[commit-bot: I haz the power, 2016-03-29 22:11:22]

Patchset 3 (id:??) landed as
https://crrev.com/2f961ea9dae09bab5060fa8bb80584144f11276b
Cr-Commit-Position: refs/heads/master@{#383844}