chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java - Issue 1841103002: [OfflinePages] Adding tests to OfflinePageBridge#getAllPagesAsync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1841103002: [OfflinePages] Adding tests to OfflinePageBridge#getAllPagesAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Extracting 2 methods from tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

index 3aaff0c6829f13da0b68f430a6520bb5c45ab0fd..dc02b4f1b9184c3f215a967a5a03aec81a664763 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

@@ -690,8 +690,8 @@ public class OfflinePageBridge {

private static native boolean nativeCanSavePage(String url);

private static native OfflinePageBridge nativeGetOfflinePageBridgeForProfile(Profile profile);

- private native void nativeGetAllPages(

- long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);

+ @VisibleForTesting

+ native void nativeGetAllPages(long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);

@VisibleForTesting

native long[] nativeGetOfflineIdsForClientId(

« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java » ('j') | no next file with comments »