Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3849)

Unified Diff: chrome/browser/ui/webui/settings_utils_unittest.cc

Issue 1841083005: Options: disallow bad URLs from being entered as startup pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup-browser-proxy
Patch Set: fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings_utils_unittest.cc
diff --git a/chrome/browser/ui/webui/settings_utils_unittest.cc b/chrome/browser/ui/webui/settings_utils_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..78f175e3727c6c7aae0c65b600ebf5986d8d7901
--- /dev/null
+++ b/chrome/browser/ui/webui/settings_utils_unittest.cc
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/settings_utils.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace settings_utils {
+
+TEST(SettingsUtilsTest, FixupAndValidateStartupPage) {
+ EXPECT_FALSE(FixupAndValidateStartupPage(std::string(), nullptr));
+ EXPECT_FALSE(FixupAndValidateStartupPage(" ", nullptr));
+ EXPECT_FALSE(FixupAndValidateStartupPage("^&*@)^)", nullptr));
+ EXPECT_FALSE(FixupAndValidateStartupPage("chrome://quit", nullptr));
+
+ EXPECT_TRUE(FixupAndValidateStartupPage("facebook.com", nullptr));
+ EXPECT_TRUE(FixupAndValidateStartupPage("http://reddit.com", nullptr));
+ EXPECT_TRUE(FixupAndValidateStartupPage("https://google.com", nullptr));
+ EXPECT_TRUE(FixupAndValidateStartupPage("chrome://apps", nullptr));
dpapad 2016/03/31 20:34:08 Can we add one case where the 2nd parameter is use
Dan Beam 2016/03/31 22:04:40 Done.
+}
+
+} // namespace settings_utils

Powered by Google App Engine
This is Rietveld 408576698