Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/ui/webui/settings_utils.cc

Issue 1841083005: Options: disallow bad URLs from being entered as startup pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup-browser-proxy
Patch Set: fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings_utils.cc
diff --git a/chrome/browser/ui/webui/settings_utils.cc b/chrome/browser/ui/webui/settings_utils.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2e3200d8080b09ed9567087ed527a50524b8353d
--- /dev/null
+++ b/chrome/browser/ui/webui/settings_utils.cc
@@ -0,0 +1,22 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/settings_utils.h"
+
+#include "chrome/browser/extensions/extension_tab_util.h"
+#include "components/url_formatter/url_fixer.h"
+#include "url/gurl.h"
+
+namespace settings_utils {
+
+bool FixupAndValidateStartupPage(const std::string& url_string,
+ GURL* url_fixed) {
dpapad 2016/03/31 20:34:08 Nit: s/url_fixed/fixed_url, or change startup_page
Dan Beam 2016/03/31 22:04:40 Done.
+ GURL url = url_formatter::FixupURL(url_string, std::string());
+ bool valid = url.is_valid() && !extensions::ExtensionTabUtil::IsKillURL(url);
+ if (valid && url_fixed)
+ url_fixed->Swap(&url);
+ return valid;
+}
+
+} // namespace settings_utils

Powered by Google App Engine
This is Rietveld 408576698