Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1841043002: Represent speed in GCTracer functions as double instead of int. (Closed)

Created:
4 years, 8 months ago by ulan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Represent speed in GCTracer functions as double instead of int. This avoids redundant casts, loss of precision, and potential overflows. BUG=chromium:597310 LOG=NO Committed: https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6 Cr-Commit-Position: refs/heads/master@{#35113}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -186 lines) Patch
M src/heap/gc-idle-time-handler.h View 2 chunks +7 lines, -17 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 chunks +10 lines, -43 lines 0 comments Download
M src/heap/gc-tracer.h View 3 chunks +10 lines, -10 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 8 chunks +20 lines, -27 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/heap/scavenge-job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/scavenge-job.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M test/unittests/heap/gc-tracer-unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/heap/scavenge-job-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
ulan
PTAL
4 years, 8 months ago (2016-03-29 13:54:27 UTC) #5
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-03-29 14:14:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841043002/20001
4 years, 8 months ago (2016-03-29 16:39:41 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 17:01:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841043002/20001
4 years, 8 months ago (2016-03-29 17:31:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 17:33:41 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:34:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6
Cr-Commit-Position: refs/heads/master@{#35113}

Powered by Google App Engine
This is Rietveld 408576698