Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: src/heap/gc-idle-time-handler.h

Issue 1841043002: Represent speed in GCTracer functions as double instead of int. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-idle-time-handler.h
diff --git a/src/heap/gc-idle-time-handler.h b/src/heap/gc-idle-time-handler.h
index 74ef1b1e8778de3ff46368aa808e36787b61e019..39dea7e1ff942c7d4e9c78004c6f184a2b3f9b3f 100644
--- a/src/heap/gc-idle-time-handler.h
+++ b/src/heap/gc-idle-time-handler.h
@@ -90,9 +90,6 @@ class GCIdleTimeHandler {
static const size_t kInitialConservativeFinalIncrementalMarkCompactSpeed =
2 * MB;
- // Maximum mark-compact time returned by EstimateMarkCompactTime.
- static const size_t kMaxMarkCompactTimeInMs;
-
// Maximum final incremental mark-compact time returned by
// EstimateFinalIncrementalMarkCompactTime.
static const size_t kMaxFinalIncrementalMarkCompactTimeInMs;
@@ -130,27 +127,20 @@ class GCIdleTimeHandler {
void ResetNoProgressCounter() { idle_times_which_made_no_progress_ = 0; }
- static size_t EstimateMarkingStepSize(size_t idle_time_in_ms,
- size_t marking_speed_in_bytes_per_ms);
-
- static size_t EstimateMarkCompactTime(
- size_t size_of_objects, size_t mark_compact_speed_in_bytes_per_ms);
-
- static size_t EstimateFinalIncrementalMarkCompactTime(
- size_t size_of_objects, size_t mark_compact_speed_in_bytes_per_ms);
+ static size_t EstimateMarkingStepSize(double idle_time_in_ms,
+ double marking_speed_in_bytes_per_ms);
- static bool ShouldDoMarkCompact(size_t idle_time_in_ms,
- size_t size_of_objects,
- size_t mark_compact_speed_in_bytes_per_ms);
+ static double EstimateFinalIncrementalMarkCompactTime(
+ size_t size_of_objects, double mark_compact_speed_in_bytes_per_ms);
static bool ShouldDoContextDisposalMarkCompact(int context_disposed,
double contexts_disposal_rate);
static bool ShouldDoFinalIncrementalMarkCompact(
- size_t idle_time_in_ms, size_t size_of_objects,
- size_t final_incremental_mark_compact_speed_in_bytes_per_ms);
+ double idle_time_in_ms, size_t size_of_objects,
+ double final_incremental_mark_compact_speed_in_bytes_per_ms);
- static bool ShouldDoOverApproximateWeakClosure(size_t idle_time_in_ms);
+ static bool ShouldDoOverApproximateWeakClosure(double idle_time_in_ms);
private:
GCIdleTimeAction NothingOrDone(double idle_time_in_ms);
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698