android: Remove unneeded md5sum class for jar.py and jar_toc.py.

android: Remove unneeded md5sum class for jar.py and jar_toc.py.

Both actions have a small fixed list of inputs. md5sum is only needed for
variable input lists (see bug). No behavior change.

BUG=177552
R=cjhopman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255436

[Nico, 2014-03-06 20:48:02]

Thank you for patiently teaching me how the android build works :-)

https://codereview.chromium.org/184103038/diff/1/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/184103038/diff/1/build/java_apk.gypi#newcode608
build/java_apk.gypi:608: '--stamp=<(jar_stamp)',
I noticed that nothing depends on jar_stamp (and that there's no jar_toc in this
file). It looks like dex_action.py uses classes_final_dir directly.

What are the jar files written by this action used for?

[cjhopman, 2014-03-06 21:25:27]

lgtm

https://codereview.chromium.org/184103038/diff/1/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/184103038/diff/1/build/java_apk.gypi#newcode608
build/java_apk.gypi:608: '--stamp=<(jar_stamp)',
On 2014/03/06 20:48:02, Nico wrote:
> I noticed that nothing depends on jar_stamp (and that there's no jar_toc in
this
> file). It looks like dex_action.py uses classes_final_dir directly.
> 
> What are the jar files written by this action used for?

The jar is used by dependents via `apk_output_jar_path` above, which just
happens to be the same as `jar_path` (this should be fixed to actually use
`jar_path` there). There is then a target (like content_shell_apk_java) that
depends on the apk target and acts like a normal java library target to its
dependents. This is needed so that the tests can refer to the classes included
in the apk here.

Really though, it's a total hack. Instead it should be inverted and the
java_apk.gypi shouldn't deal directly with java files or resources. Instead
java+resources should be extracted out to a seperate library target and then the
apk and test targets can both just depend on that (and then java_apk.gypi really
does just package stuff together into an apk).

[Nico, 2014-03-06 21:41:24]

Committed patchset #1 manually as r255436 (presubmit successful).