android: Remove unneeded md5sum class for jar.py and jar_toc.py.

build/java_apk.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file is meant to be included into a target to provide a rule
 # to build Android APKs in a consistent manner.
 #
 # To use this, create a gyp target with the following form:
 # {
 #   'target_name': 'my_package_apk',
@@ skipping 574 matching lines @@
       ],
       'outputs': [
         '<(instr_stamp)',
       ],
       'includes': [ 'android/instr_action.gypi' ],
     },
     {
       'action_name': 'jar_<(_target_name)',
       'message': 'Creating <(_target_name) jar',
       'inputs': [
-        '<(instr_stamp)',
         '<(DEPTH)/build/android/gyp/util/build_utils.py',
         '<(DEPTH)/build/android/gyp/util/md5_check.py',
         '<(DEPTH)/build/android/gyp/jar.py',
+        '<(instr_stamp)',
       ],
       'outputs': [
         '<(jar_stamp)',
       ],
       'action': [
         'python', '<(DEPTH)/build/android/gyp/jar.py',
         '--classes-dir=<(classes_final_dir)',
         '--jar-path=<(jar_path)',
         '--excluded-classes=<(jar_excluded_classes)',
         '--stamp=<(jar_stamp)',

[Nico, 2014/03/06 20:48:02]

I noticed that nothing depends on jar_stamp (and that there's no jar_toc in this
file). It looks like dex_action.py uses classes_final_dir directly.

What are the jar files written by this action used for?

[cjhopman, 2014/03/06 21:25:28]

The jar is used by dependents via `apk_output_jar_path` above, which just
happens to be the same as `jar_path` (this should be fixed to actually use
`jar_path` there). There is then a target (like content_shell_apk_java) that
depends on the apk target and acts like a normal java library target to its
dependents. This is needed so that the tests can refer to the classes included
in the apk here.

Really though, it's a total hack. Instead it should be inverted and the
java_apk.gypi shouldn't deal directly with java files or resources. Instead
java+resources should be extracted out to a seperate library target and then the
apk and test targets can both just depend on that (and then java_apk.gypi really
does just package stuff together into an apk).

-
-        # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
-        '--ignore=>!(echo \'>(_inputs)\' | md5sum)',
       ]
     },
     {
       'action_name': 'ant_obfuscate_<(_target_name)',
       'message': 'Obfuscating <(_target_name)',
       'inputs': [
         '<(DEPTH)/build/android/ant/apk-obfuscate.xml',
         '<(DEPTH)/build/android/ant/create-test-jar.js',
         '<(DEPTH)/build/android/gyp/util/build_utils.py',
         '<(DEPTH)/build/android/gyp/ant.py',
@@ skipping 147 matching lines @@
         '<(DEPTH)/build/android/ant/apk-package.xml',
 
         # Add list of inputs to the command line, so if inputs change
         # (e.g. if a Java file is removed), the command will be re-run.
         # TODO(newt): remove this once crbug.com/177552 is fixed in ninja.
         '-DTHIS_IS_IGNORED=>!(echo \'>(_inputs)\' | md5sum)',
       ]
     },
   ],
 }